From: Theodore Ts'o <tytso@mit.edu>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: Andreas Dilger <adilger@dilger.ca>,
linux-ext4@vger.kernel.org,
"Darrick J. Wong" <darrick.wong@oracle.com>
Subject: Re: [PATCH v2] debugfs/set_fields: fix several errors and add assertions
Date: Fri, 19 Jun 2015 22:01:58 -0400 [thread overview]
Message-ID: <20150620020158.GD29480@thunk.org> (raw)
In-Reply-To: <20150225094728.14523.52763.stgit@buzz>
On Wed, Feb 25, 2015 at 12:47:28PM +0300, Konstantin Khlebnikov wrote:
> Fix copy-n-paste errors:
> * remove duplicate "lastcheck" and "min_extra_isize"
> * fix pointer for "first_error_line" and "last_error_line"
> * remove superblock field "inodes_count" from inode fields
> * add null-termination for mmp_fields
>
> Add assertions for catching such errors in the future.
> Mark true aliases with flag "FLAG_ALIAS" and suppress assert for them.
>
> v2: check tables in unit test "debugfs/tst_set_fields"
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Applied, thanks. Apologies for the delay.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
next prev parent reply other threads:[~2015-06-20 2:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 9:47 [PATCH v2] debugfs/set_fields: fix several errors and add assertions Konstantin Khlebnikov
2015-06-20 2:01 ` Theodore Ts'o [this message]
2015-06-20 12:30 ` Konstantin Khlebnikov
2015-06-21 21:15 ` Andreas Dilger
2015-06-21 21:29 ` Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150620020158.GD29480@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=darrick.wong@oracle.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.