[Buildroot] [PATCH 1/4] defconfig for warpboard

[Arthur LAMBERT <lambertarthur22@gmail.com>]

Le Friday 19 Jun 2015 ?? 23:48:57 (+0200), Arnout Vandecappelle a ??crit :
> On 06/19/15 17:29, Arthur LAMBERT wrote:
> > This is a set of patch to add support for warpboard (Freescale board based on imx6sl)
> >
> > Signed-off-by: Arthur LAMBERT <lambertarthur22@gmail.com>
> > ---
> >  configs/warpboard_defconfig | 31 +++++++++++++++++++++++++++++++
> >  1 file changed, 31 insertions(+)
> >  create mode 100644 configs/warpboard_defconfig
> >
> > diff --git a/configs/warpboard_defconfig b/configs/warpboard_defconfig
> > new file mode 100644
> > index 0000000..188ea4d
> > --- /dev/null
> > +++ b/configs/warpboard_defconfig
> > @@ -0,0 +1,31 @@
> > +# architecture
> > +BR2_arm=y
> > +BR2_cortex_a9=y
>
>  Please also fix the kernel headers to a specific version. Pretty soon 4.1 will
> be the default, and they may be incompatible with the kernel you build.
>

Ok my bad.

>
> > +
> > +# system
> > +BR2_TARGET_GENERIC_HOSTNAME="warpboard"
> > +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0"
> > +
> > +# kernel
> > +BR2_LINUX_KERNEL=y
> > +BR2_LINUX_KERNEL_CUSTOM_GIT=y
> > +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="git at github.com:Freescale/linux-fslc.git"
>
>  For github, we prefer to use a wget download rather than a a git download,
> since it's a lot faster. So:
>
> BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
> BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION=$(call
> github,Freescale,linux-fscl,38ec11d74b0fbe110b658a6e1a86eeac7e5a383e)
>
> > +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="patches-4.0"
>
>  This is a branch, not a tag, so it's a moving target. Since there don't seem to
> be tags in this repository, you'll have to specify a commit sha instead (as I've
> shown above).
>

Ok I will also fix that.

>
> > +BR2_LINUX_KERNEL_PATCH="board/freescale/warpboard/linux/"
> > +BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
> > +BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/freescale/warpboard/linux-4.0.config"
>
>  You forgot to include this file in the patch. Please make sure that it's a
> defconfig, not a full config.
>

This file is present later in a different email.
git send email command send a mail per commit. Do I use the good process to provide my patch ? Do you prefer to put all the patch in the same email ?


> > +BR2_LINUX_KERNEL_ZIMAGE=y
> > +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> > +BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6sl-warp"
> > +
> > +# rootfs
> > +BR2_TARGET_ROOTFS_EXT2=y
> > +BR2_TARGET_ROOTFS_EXT2_4=y
> > +BR2_TARGET_ROOTFS_TAR_BZIP2=y
>
>  We generally don't make a tarball at all, since the ext4 is enough.
>
> > +BR2_ROOTFS_OVERLAY="board/freescale/warpboard/rootfs_overlay"
>
>  Also this is missing. Why is an overlay needed to begin with?
>
> > +
> > +# bootloader
> > +BR2_TARGET_UBOOT=y
> > +BR2_TARGET_UBOOT_VERSION="2015.04"
>
>  This can't be right, BR2_TARGET_UBOOT_VERSION is a hidden symbol. It should be:
>
> BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2015.04"
>
> > +BR2_TARGET_UBOOT_BOARDNAME="warp"
> > +BR2_TARGET_UBOOT_FORMAT_IMX=y
>

I will fix that

>
>  We also usually add a readme.txt file with an explanation of how to put
> everything on an SD card.
>

There is no sdcard port available on warpboard. The only way to flash it is to used dfu/imx_usb_loader.
But you right, I will add in a README a process to flash the board.

>  Regards,
>  Arnout
>

Regards,
Arthur.

>
> --
> Arnout Vandecappelle                          arnout at mind be
> Senior Embedded Software Architect            +32-16-286500
> Essensium/Mind                                http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F