From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
Benjamin LaHaise <bcrl@kvack.org>,
Hugh Dickins <hughd@google.com>, Jeff Moyer <jmoyer@redhat.com>,
Kirill Shutemov <kirill.shutemov@linux.intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] special_mapping_fault() is broken
Date: Sun, 21 Jun 2015 23:07:25 +0200 [thread overview]
Message-ID: <20150621210725.GA18220@redhat.com> (raw)
On 06/20, Oleg Nesterov wrote:
>
> Let me first send the changes which look "obviously correct" to me.
> Perhaps I'll send more patches on top of this later.
But lets also fix another unmap/remap bug before the cleanups...
This series doesn't depend on the previous mremap fixes.
special_mapping_fault() is absolutely broken. It seems it was always
wrong, but this didn't matter until vdso/vvar started to use more than
one page.
I am not sure about 1/3. As the changelog says the name is not very
accurate, and I do not really like the vma->fault != NULL check. But
I hope this can work, and we can change this helper later if needed.
Please review.
Oleg.
include/linux/mm.h | 5 +++++
mm/memory.c | 13 ++++++-------
mm/mmap.c | 14 +++-----------
3 files changed, 14 insertions(+), 18 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
next reply other threads:[~2015-06-21 21:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-21 21:07 Oleg Nesterov [this message]
2015-06-21 21:07 ` [PATCH 1/3] mm: introduce vma_is_anonymous(vma) helper Oleg Nesterov
2015-06-21 21:07 ` [PATCH 2/3] mmap: fix the usage of ->vm_pgoff in special_mapping paths Oleg Nesterov
2015-06-21 21:07 ` [PATCH 3/3] mremap: fix the wrong !vma->vm_file check in copy_vma() Oleg Nesterov
2015-06-21 21:19 ` [PATCH 0/3] special_mapping_fault() is broken Oleg Nesterov
2015-06-23 0:47 ` vdso && f_op->mremap (Was: special_mapping_fault() is broken) Oleg Nesterov
2015-06-23 1:09 ` Linus Torvalds
2015-06-23 1:26 ` Andy Lutomirski
2015-06-23 15:04 ` Pavel Emelyanov
2015-06-23 17:03 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150621210725.GA18220@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=hughd@google.com \
--cc=jmoyer@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.