All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: pbonzini@redhat.com, bsd@redhat.com, qemu-devel@nongnu.org,
	rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v2] target-i386: emulate CPUID level of real hardware
Date: Mon, 22 Jun 2015 12:41:48 +0200	[thread overview]
Message-ID: <20150622104147.GA26985@potion.redhat.com> (raw)
In-Reply-To: <20150619155248.GP3874@thinpad.lan.raisama.net>

2015-06-19 12:52-0300, Eduardo Habkost:
> On Fri, Jun 19, 2015 at 01:20:40PM +0200, Radim Krčmář wrote:
> [...]
> > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> > @@ -307,6 +307,24 @@ static void pc_init1(MachineState *machine)
> >  static void pc_compat_2_3(MachineState *machine)
> >  {
> >      savevm_skip_section_footers();
> > +
> > +    x86_cpu_compat_set_level("qemu64",   4);
| [...]
> > +
> > +    x86_cpu_compat_set_xlevel("n270",            0x8000000a);
| [...]
> 
> We can simply use set the "level" and "xlevel" properties on
> PC_COMPAT_2_3, we don't need the x86_cpu_compat_set_*level() functions.

Oops, thanks, I will convert the code and send v3.

      reply	other threads:[~2015-06-22 10:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-19 11:20 [Qemu-devel] [PATCH v2] target-i386: emulate CPUID level of real hardware Radim Krčmář
2015-06-19 15:52 ` Eduardo Habkost
2015-06-22 10:41   ` Radim Krčmář [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150622104147.GA26985@potion.redhat.com \
    --to=rkrcmar@redhat.com \
    --cc=bsd@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.