From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933296AbbFVLKa (ORCPT ); Mon, 22 Jun 2015 07:10:30 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:34318 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751136AbbFVLKW (ORCPT ); Mon, 22 Jun 2015 07:10:22 -0400 Date: Mon, 22 Jun 2015 16:40:14 +0530 From: Sudip Mukherjee To: Greg Donald Cc: Greg Kroah-Hartman , Aya Mahfouz , Haneen Mohammed , Cristina Opriceana , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors Message-ID: <20150622111014.GB3355@sudip-PC> References: <1434833768-8336-1-git-send-email-gdonald@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434833768-8336-1-git-send-email-gdonald@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 20, 2015 at 03:56:08PM -0500, Greg Donald wrote: > Fix checkpatch.pl "space required before the open parenthesis '('" errors > > Signed-off-by: Greg Donald > --- > .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 97 ++++++++++------------ > 1 file changed, 44 insertions(+), 53 deletions(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c > index c2588f8..df20979 100644 > --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c > +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c > @@ -127,8 +127,7 @@ void HTDebugHTCapability(u8 *CapIE, u8 *TitleString ) > static u8 EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33}; // For 11n EWC definition, 2007.07.17, by Emily > PHT_CAPABILITY_ELE pCapELE; > > - if(!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap))) > - { > + if (!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap))) { ^^^^^^^ this becomes a different kind of change than what is mentioned in your commit message. You are also adding space after ',' later in your patch. please do only one kind of change in one patch. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/