From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [v2 4/7] mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM Date: Tue, 23 Jun 2015 08:19:21 +0100 Message-ID: <20150623071921.GE3245@x1> References: <1434970465-12687-1-git-send-email-shobhit.kumar@intel.com> <1434970465-12687-5-git-send-email-shobhit.kumar@intel.com> <5587EB7A.5090402@gmail.com> <20150622141908.GM25769@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20150622141908.GM25769@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Varka Bhadram , Shobhit Kumar , linux-pwm , intel-gfx , linux-kernel , dri-devel , linux-gpio , Alexandre Courbot , Paul Bolle , Samuel Ortiz , Povilas Staniulis , Jani Nikula , Linus Walleij , Paul Gortmaker , bloften80@gmail.com, David Airlie , Chih-Wei Huang , Thierry Reding , Daniel Vetter List-Id: linux-gpio@vger.kernel.org T24gTW9uLCAyMiBKdW4gMjAxNSwgRGFuaWVsIFZldHRlciB3cm90ZToKCj4gT24gTW9uLCBKdW4g MjIsIDIwMTUgYXQgMDQ6MzM6MjJQTSArMDUzMCwgVmFya2EgQmhhZHJhbSB3cm90ZToKPiA+IEhp IFNob2JoaXQgS3VtYXIsCj4gPiAKPiA+IE9uIDA2LzIyLzIwMTUgMDQ6MjQgUE0sIFNob2JoaXQg S3VtYXIgd3JvdGU6Cj4gPiAKPiA+ID5PbiBzb21lIEJZVCBQTGF0Zm9ybSB0aGUgUFdNIGlzIGNv bnRyb2xsZWQgdXNpbmcgQ1JDIFBNSUMuIEFkZCBhIGxvb2t1cAo+ID4gPmVudHJ5IGZvciB0aGUg c2FtZSB0byBiZSB1c2VkIGJ5IHRoZSBjb25zdW1lciAoSW50ZWwgR0ZYKQo+ID4gPgo+ID4gPnYy OiBSZW1vdmUgdGhlIGxvb2t1cCB0YWJsZSBvbiBkcml2ZXIgdW5sb2FkIChUaGllcnJ5KQo+ID4g Pgo+ID4gPnYzOiBDb3JyZWN0IHRoZSBzdWJqZWN0IGxpbmUgKExlZSBqb25lcykKPiA+IAo+ID4g VGhpcyBwYXJ0IHNob3VsZCBvbmx5IGRlc2NyaWJlIHdoYXQgdGhpcyBpcyBhYm91dC4uCj4gPiAK PiA+IERvbid0IHB1dCB0aGlzIHBhdGNoIGNoYW5nZSBoaXN0b3J5IG92ZXIgaGVyZS4KPiA+IElu Y2x1ZGUgdGhpcyBjaGFuZ2UgaGlzdG9yeSBhZnRlcgo+ID4gLi4uCj4gPiBTaWduZWQtb2ZmLWJ5 OiBBdXRob3IgPGVtYWlsPgo+ID4gLS0tCj4gPiAKPiA+ID5DQzogU2FtdWVsIE9ydGl6IDxzYW1l b0BsaW51eC5pbnRlbC5jb20+Cj4gPiA+Q2M6IExpbnVzIFdhbGxlaWogPGxpbnVzLndhbGxlaWpA bGluYXJvLm9yZz4KPiA+ID5DYzogQWxleGFuZHJlIENvdXJib3QgPGdudXJvdUBnbWFpbC5jb20+ Cj4gPiA+Q2M6IFRoaWVycnkgUmVkaW5nIDx0aGllcnJ5LnJlZGluZ0BnbWFpbC5jb20+Cj4gPiA+ QWNrZWQtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4gPiA+U2lnbmVkLW9m Zi1ieTogU2hvYmhpdCBLdW1hciA8c2hvYmhpdC5rdW1hckBpbnRlbC5jb20+Cj4gPiA+LS0tCj4g PiAKPiA+IEhlcmUgeW91IGFkZCB0aGlzIGNoYW5nZSBoaXN0b3J5IHNvIHRoYXQgYWZ0ZXIgYXBw bHlpbmcgdGhpcwo+ID4gd2lsbCBub3QgYmUgdGhlIHBhcnQgb2YgeW91ciBjb21taXQgZGVzY3Jp cHRpb24uCj4gPiAKPiA+IFRoaXMgY29tbWVudCBpcyBhcHBsaWNhYmxlIGZvciBhbGwgb2YgeW91 ciBwYXRjaGVzLgo+IAo+IEl0J3MgaG9uZXN0bHkgYSBwZXItbWFpbnRhaW5lciB0aGluZyBhbmQg aGFyZCB0byB0ZWxsIHdobyB3YW50cyB3aGF0IC4uLgo+IFBlcnNvbmFsbHkgSSBkbyB3YW50IHRv IGluY2x1ZGUgdGhlIHBhdGNoIGNoYW5nZWxvZyBpbiB0aGUgY29tbWl0IG1lc3NhZ2UuCgpUaGUg cGF0Y2ggY2hhbmdlLWxvZyBzaG91bGQgZ28gYmVsb3cgdGhlICctLS0nLiAgVGhlcmUgYXJlIHZl cnkgZmV3Cih3ZWlyZCA7KSApIE1haW50YWluZXJzIHdobyBsaWtlIHRvIHNlZSB0aGVtIGluIHRo ZSBjb21taXQgbG9nLgoKLS0gCkxlZSBKb25lcwpMaW5hcm8gU1RNaWNyb2VsZWN0cm9uaWNzIExh bmRpbmcgVGVhbSBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBB Uk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753509AbbFWHTo (ORCPT ); Tue, 23 Jun 2015 03:19:44 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:35125 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753840AbbFWHT0 (ORCPT ); Tue, 23 Jun 2015 03:19:26 -0400 Date: Tue, 23 Jun 2015 08:19:21 +0100 From: Lee Jones To: Varka Bhadram , Shobhit Kumar , linux-pwm , intel-gfx , linux-kernel , dri-devel , linux-gpio , Alexandre Courbot , Paul Bolle , Samuel Ortiz , Povilas Staniulis , Jani Nikula , Linus Walleij , Paul Gortmaker , bloften80@gmail.com, David Airlie , Chih-Wei Huang , Thierry Reding , Daniel Vetter Subject: Re: [Intel-gfx] [v2 4/7] mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM Message-ID: <20150623071921.GE3245@x1> References: <1434970465-12687-1-git-send-email-shobhit.kumar@intel.com> <1434970465-12687-5-git-send-email-shobhit.kumar@intel.com> <5587EB7A.5090402@gmail.com> <20150622141908.GM25769@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150622141908.GM25769@phenom.ffwll.local> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Jun 2015, Daniel Vetter wrote: > On Mon, Jun 22, 2015 at 04:33:22PM +0530, Varka Bhadram wrote: > > Hi Shobhit Kumar, > > > > On 06/22/2015 04:24 PM, Shobhit Kumar wrote: > > > > >On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup > > >entry for the same to be used by the consumer (Intel GFX) > > > > > >v2: Remove the lookup table on driver unload (Thierry) > > > > > >v3: Correct the subject line (Lee jones) > > > > This part should only describe what this is about.. > > > > Don't put this patch change history over here. > > Include this change history after > > ... > > Signed-off-by: Author > > --- > > > > >CC: Samuel Ortiz > > >Cc: Linus Walleij > > >Cc: Alexandre Courbot > > >Cc: Thierry Reding > > >Acked-by: Lee Jones > > >Signed-off-by: Shobhit Kumar > > >--- > > > > Here you add this change history so that after applying this > > will not be the part of your commit description. > > > > This comment is applicable for all of your patches. > > It's honestly a per-maintainer thing and hard to tell who wants what ... > Personally I do want to include the patch changelog in the commit message. The patch change-log should go below the '---'. There are very few (weird ;) ) Maintainers who like to see them in the commit log. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/