diff for duplicates of <20150623092303.GN28762@mwanda> diff --git a/a/1.txt b/N1/1.txt index 0a3e4df..885537d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -9,7 +9,7 @@ do: instead of: - if (ret = 1) + if (ret == 1) but that bug is something else besides pointers so it doesn't apply here. @@ -21,7 +21,7 @@ that (NULL != foo) is the worst way to write it because of the double negative Yoda code. Yoda code is the most useless thing ever. I have actually measured this -and we introduce about 2 = vs = bugs per year. It's probably less now +and we introduce about 2 = vs == bugs per year. It's probably less now that we have so many static checks against it. But people decided that Yoda code was a good idea based on their gut instead of using statistics and measurements and science. diff --git a/a/content_digest b/N1/content_digest index 819a250..bdfda62 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,18 +2,9 @@ "ref\01434819550-3193-2-git-send-email-Julia.Lawall@lip6.fr\0" "ref\0D1AECA61.F8DE5%andreas.dilger@intel.com\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" - "Subject\0Re: [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure\0" - "Date\0Tue, 23 Jun 2015 09:23:03 +0000\0" - "To\0Dilger" - " Andreas <andreas.dilger@intel.com>\0" - "Cc\0Julia Lawall <Julia.Lawall@lip6.fr>" - Drokin - Oleg <oleg.drokin@intel.com> - devel@driverdev.osuosl.org <devel@driverdev.osuosl.org> - Greg Kroah-Hartman <gregkh@linuxfoundation.org> - kernel-janitors@vger.kernel.org <kernel-janitors@vger.kernel.org> - linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> - " lustre-devel@lists.lustre.org <lustre-devel@lists.lustre.org>\0" + "Subject\0[lustre-devel] [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure\0" + "Date\0Tue, 23 Jun 2015 12:23:03 +0300\0" + "To\0lustre-devel@lists.lustre.org\0" "\00:1\0" "b\0" "On Tue, Jun 23, 2015 at 08:25:05AM +0000, Dilger, Andreas wrote:\n" @@ -27,7 +18,7 @@ "\n" "instead of:\n" "\n" - "\tif (ret = 1)\n" + "\tif (ret == 1)\n" "\n" "but that bug is something else besides pointers so it doesn't apply\n" "here.\n" @@ -39,7 +30,7 @@ "negative Yoda code.\n" "\n" "Yoda code is the most useless thing ever. I have actually measured this\n" - "and we introduce about 2 = vs = bugs per year. It's probably less now\n" + "and we introduce about 2 = vs == bugs per year. It's probably less now\n" "that we have so many static checks against it. But people decided that\n" "Yoda code was a good idea based on their gut instead of using statistics\n" "and measurements and science.\n" @@ -47,4 +38,4 @@ "regards,\n" dan carpenter -83be7a1fd4ac4ead644d4984f88a7038751416e396ec50a6b4a456c2efd30b8e +cd7d92687bd323a91b0e6740e32a84a4af3716adf34f91070c4edb0b3ece28cc
diff --git a/a/1.txt b/N2/1.txt index 0a3e4df..885537d 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -9,7 +9,7 @@ do: instead of: - if (ret = 1) + if (ret == 1) but that bug is something else besides pointers so it doesn't apply here. @@ -21,7 +21,7 @@ that (NULL != foo) is the worst way to write it because of the double negative Yoda code. Yoda code is the most useless thing ever. I have actually measured this -and we introduce about 2 = vs = bugs per year. It's probably less now +and we introduce about 2 = vs == bugs per year. It's probably less now that we have so many static checks against it. But people decided that Yoda code was a good idea based on their gut instead of using statistics and measurements and science. diff --git a/a/content_digest b/N2/content_digest index 819a250..31ad713 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,7 +3,7 @@ "ref\0D1AECA61.F8DE5%andreas.dilger@intel.com\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure\0" - "Date\0Tue, 23 Jun 2015 09:23:03 +0000\0" + "Date\0Tue, 23 Jun 2015 12:23:03 +0300\0" "To\0Dilger" " Andreas <andreas.dilger@intel.com>\0" "Cc\0Julia Lawall <Julia.Lawall@lip6.fr>" @@ -27,7 +27,7 @@ "\n" "instead of:\n" "\n" - "\tif (ret = 1)\n" + "\tif (ret == 1)\n" "\n" "but that bug is something else besides pointers so it doesn't apply\n" "here.\n" @@ -39,7 +39,7 @@ "negative Yoda code.\n" "\n" "Yoda code is the most useless thing ever. I have actually measured this\n" - "and we introduce about 2 = vs = bugs per year. It's probably less now\n" + "and we introduce about 2 = vs == bugs per year. It's probably less now\n" "that we have so many static checks against it. But people decided that\n" "Yoda code was a good idea based on their gut instead of using statistics\n" "and measurements and science.\n" @@ -47,4 +47,4 @@ "regards,\n" dan carpenter -83be7a1fd4ac4ead644d4984f88a7038751416e396ec50a6b4a456c2efd30b8e +ffb17cdd2bbc626f38972dfa6a1786115e197a8679bdb3288407fa1bd8497621
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.