diff for duplicates of <20150623095704.GO28762@mwanda> diff --git a/a/1.txt b/N1/1.txt index cd0eef8..f0bc8dd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,8 +1,8 @@ Yes. I know Al's thoughts and kernel style. -But Alan Cox and Andreas have both said they think (x = NULL) can help +But Alan Cox and Andreas have both said they think (x == NULL) can help you avoid some kind of boolean vs pointer bugs. I've had co-workers who -did massive seds changing !foo to foo = NULL on our code base. But +did massive seds changing !foo to foo == NULL on our code base. But I've never seen a real life example of a bug this fixes. To be honest, I've never seen a real life proof that (!foo) code is less diff --git a/a/content_digest b/N1/content_digest index dd5eb0f..0ac88ce 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,25 +4,16 @@ "ref\020150623092303.GN28762@mwanda\0" "ref\0alpine.DEB.2.10.1506231127120.2554@hadrien\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" - "Subject\0Re: [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure\0" - "Date\0Tue, 23 Jun 2015 09:57:04 +0000\0" - "To\0Julia Lawall <julia.lawall@lip6.fr>\0" - "Cc\0devel@driverdev.osuosl.org <devel@driverdev.osuosl.org>" - Dilger - Andreas <andreas.dilger@intel.com> - Greg Kroah-Hartman <gregkh@linuxfoundation.org> - kernel-janitors@vger.kernel.org <kernel-janitors@vger.kernel.org> - linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> - Drokin - Oleg <oleg.drokin@intel.com> - " lustre-devel@lists.lustre.org <lustre-devel@lists.lustre.org>\0" + "Subject\0[lustre-devel] [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure\0" + "Date\0Tue, 23 Jun 2015 12:57:04 +0300\0" + "To\0lustre-devel@lists.lustre.org\0" "\00:1\0" "b\0" "Yes. I know Al's thoughts and kernel style.\n" "\n" - "But Alan Cox and Andreas have both said they think (x = NULL) can help\n" + "But Alan Cox and Andreas have both said they think (x == NULL) can help\n" "you avoid some kind of boolean vs pointer bugs. I've had co-workers who\n" - "did massive seds changing !foo to foo = NULL on our code base. But\n" + "did massive seds changing !foo to foo == NULL on our code base. But\n" "I've never seen a real life example of a bug this fixes.\n" "\n" "To be honest, I've never seen a real life proof that (!foo) code is less\n" @@ -38,4 +29,4 @@ "regards,\n" dan carpenter -81a3b626e7c1877e8213353823fd785c40cb77131bd257959ef19b7f7aec6b7d +b5d0db04d429ff5383604f8a9afe7057a1292cc4845f67e084e2e920a0cb77ce
diff --git a/a/1.txt b/N2/1.txt index cd0eef8..f0bc8dd 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,8 +1,8 @@ Yes. I know Al's thoughts and kernel style. -But Alan Cox and Andreas have both said they think (x = NULL) can help +But Alan Cox and Andreas have both said they think (x == NULL) can help you avoid some kind of boolean vs pointer bugs. I've had co-workers who -did massive seds changing !foo to foo = NULL on our code base. But +did massive seds changing !foo to foo == NULL on our code base. But I've never seen a real life example of a bug this fixes. To be honest, I've never seen a real life proof that (!foo) code is less diff --git a/a/content_digest b/N2/content_digest index dd5eb0f..a54262b 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -5,7 +5,7 @@ "ref\0alpine.DEB.2.10.1506231127120.2554@hadrien\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure\0" - "Date\0Tue, 23 Jun 2015 09:57:04 +0000\0" + "Date\0Tue, 23 Jun 2015 12:57:04 +0300\0" "To\0Julia Lawall <julia.lawall@lip6.fr>\0" "Cc\0devel@driverdev.osuosl.org <devel@driverdev.osuosl.org>" Dilger @@ -20,9 +20,9 @@ "b\0" "Yes. I know Al's thoughts and kernel style.\n" "\n" - "But Alan Cox and Andreas have both said they think (x = NULL) can help\n" + "But Alan Cox and Andreas have both said they think (x == NULL) can help\n" "you avoid some kind of boolean vs pointer bugs. I've had co-workers who\n" - "did massive seds changing !foo to foo = NULL on our code base. But\n" + "did massive seds changing !foo to foo == NULL on our code base. But\n" "I've never seen a real life example of a bug this fixes.\n" "\n" "To be honest, I've never seen a real life proof that (!foo) code is less\n" @@ -38,4 +38,4 @@ "regards,\n" dan carpenter -81a3b626e7c1877e8213353823fd785c40cb77131bd257959ef19b7f7aec6b7d +839fe6f67bad8beabfa4dab834aed4e5ebe8059d3bc9b45540b5248b5f5b15e4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.