All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] introduce "preciousObjects" repository extension
Date: Tue, 23 Jun 2015 07:47:45 -0400	[thread overview]
Message-ID: <20150623114745.GA3845@peff.net> (raw)
In-Reply-To: <CACsJy8AR_vZLAAKf4P+aEtKu1u35N8kAYtYLNOg55ET8DWeZUA@mail.gmail.com>

On Tue, Jun 23, 2015 at 06:14:22PM +0700, Duy Nguyen wrote:

> > +       if (delete_redundant && repository_format_precious_objects)
> > +               die("cannot repack in a precious-objects repo");
> > +
> >         if (pack_kept_objects < 0)
> >                 pack_kept_objects = write_bitmaps;
> >
> 
> I know both commands have translatable strings that are not marked
> with _(). But if you reroll, maybe you could add _() for these new
> strings. It's even better if you mark all others in these commands
> too, if you have time.

Yeah, I agree these should be marked for translation. Thanks.

-Peff

  reply	other threads:[~2015-06-23 11:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 10:50 [RFC/PATCH 0/2] bumping repository format version Jeff King
2015-06-23 10:53 ` [PATCH 1/2] introduce "extensions" form of core.repositoryformatversion Jeff King
2015-06-23 10:54 ` [PATCH 2/2] introduce "preciousObjects" repository extension Jeff King
2015-06-23 11:14   ` Duy Nguyen
2015-06-23 11:47     ` Jeff King [this message]
2015-06-23 21:05   ` Junio C Hamano
2015-06-24  7:50     ` Jeff King
2015-06-24 17:15       ` Junio C Hamano
2015-06-25 10:07         ` Jeff King
2015-06-23 21:31   ` David Turner
2015-06-24  7:55     ` Jeff King
2015-06-24  8:12   ` Jeff King
2015-06-24 10:29     ` Duy Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150623114745.GA3845@peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.