From: Daniel Vetter <daniel@ffwll.ch>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Daniel Veter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove KMS Kconfig option
Date: Tue, 23 Jun 2015 14:04:41 +0200 [thread overview]
Message-ID: <20150623120441.GY25769@phenom.ffwll.local> (raw)
In-Reply-To: <55893905.3030401@linux.intel.com>
On Tue, Jun 23, 2015 at 11:46:29AM +0100, Tvrtko Ursulin wrote:
>
> On 06/22/2015 03:17 PM, Daniel Vetter wrote:
> >On Mon, Jun 22, 2015 at 12:11:47PM +0100, Damien Lespiau wrote:
> >>On Fri, Jun 19, 2015 at 08:27:27PM +0100, Chris Wilson wrote:
> >>>Since we only support modesetting by default (disabling modesetting on
> >>>the command line prevents i915.ko from loading), having a parameter to
> >>>disable modesstting by default is superfluous, i.e. saying
> >>>CONFIG_DRM_I915_KMS=n is equivalent to CONFIG_DRM_I915=n.
> >>>
> >>>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >>>Cc: Daniel Veter <daniel.vetter@ffwll.ch>
> >>
> >>Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
> >
> >Slight chance someone with an ums-only setup will get pissed about this.
> >But surely interesting to hear about those ;-)
>
> i915_drv.c:
>
> #if defined(CONFIG_DRM_I915_KMS)
> MODULE_DEVICE_TABLE(pci, pciidlist);
> #endif
>
> Ooops! :)
Indeed. Patch submitted and dinq history rectified.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-06-23 12:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 19:27 [PATCH] drm/i915: Remove KMS Kconfig option Chris Wilson
2015-06-22 11:11 ` Damien Lespiau
2015-06-22 14:17 ` Daniel Vetter
2015-06-23 10:46 ` Tvrtko Ursulin
2015-06-23 12:04 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623120441.GY25769@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.