Re: [PATCH] NFC: nxp-nci_i2c: use flags argument of devm_gpiod_get_index

["Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>]

Hello,

On Wed, Jun 17, 2015 at 11:10:52AM +0200, Uwe Kleine-König wrote:
> Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions)
> which appeared in v3.17-rc1, the gpiod_get* functions take an additional
> parameter that allows to specify direction and initial value for output.
> 
> Simplify driver accordingly which even make error checking more correct
I did s/make/makes/ in my tree.

> because gpiod_direction_{in,out}put might fail. Furthermore this is one
> caller less that stops us making the flags argument to gpiod_get*()
> mandatory.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
> 
> I intend to make the flags parameter to gpiod_get* mandatory once
> 4.2-rc1 arrives. So unless this patch makes it in, I'd like to get an
> Ack to take it via the gpio tree together with the change to gpiod_get.
> 
> Note this patch depends on 
> 551e306905ef (NFC: nxp-nci_i2c: Add support for enumerating through ACPI)
> which only appeared in today's next.
This still applies. So an ack would be very welcome.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |