From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: Linux 4.1 WARNING in drm_ioctl.c Date: Tue, 23 Jun 2015 15:29:41 +0200 Message-ID: <20150623132941.GC25769@phenom.ffwll.local> References: <34169093.qYXxFR1FLt@calvin> <20150623094847.GR25769@phenom.ffwll.local> <3759620.yiBZ6BaR05@calvin> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by gabe.freedesktop.org (Postfix) with ESMTP id BDF9F7A126 for ; Tue, 23 Jun 2015 06:26:54 -0700 (PDT) Received: by wicnd19 with SMTP id nd19so105910093wic.1 for ; Tue, 23 Jun 2015 06:26:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: <3759620.yiBZ6BaR05@calvin> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Fabio Coatti Cc: dri-devel , kernel list List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKdW4gMjMsIDIwMTUgYXQgMTI6NDY6MDlQTSArMDIwMCwgRmFiaW8gQ29hdHRpIHdy b3RlOgo+IEluIGRhdGEgbWFydGVkw6wgMjMgZ2l1Z25vIDIwMTUgMTE6NDg6NDcsIERhbmllbCBW ZXR0ZXIgaGEgc2NyaXR0bzoKPiA+IE9uIFR1ZSwgSnVuIDIzLCAyMDE1IGF0IDA4OjI3OjEzQU0g KzAxMDAsIERhbmllbCBTdG9uZSB3cm90ZToKPiA+ID4gSGksCj4gPiA+IAo+ID4gPiBPbiAyMyBK dW5lIDIwMTUgYXQgMDc6MzksIERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4gd3JvdGU6 Cj4gPiA+ID4gV2hpY2ggZHJtIGRyaXZlciBhcmUgeW91IHVzaW5nPyBJIGRpZG4ndCBzcG90IGFu eXRoaW5nIGluIHlvdXIgbW9kdWxlCj4gPiA+ID4gbGlzdAo+ID4gPiA+IGJ1dCBtaWdodCBoYXZl IG1pc3NlZCBpdC4gQm9vdGluZyB3aXRoIGRybS5kZWJ1Zz0weGUgYW5kIGdyYWJiaW5nIGRtZXNn Cj4gPiA+ID4gd2lsbCB0ZWxsIHVzIGZvciBzdXJlLgo+ID4gPiAKPiA+ID4gVGhhdCdkIGJlIHZn ZW0uCj4gPiAKPiA+IElmIHNvIHRoZW4gdGhlIGJlbG93IGRpZmYgc2hvdWxkIGhlbHAuCj4gPiAt RGFuaWVsCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3ZnZW0vdmdlbV9kcnYuYwo+ ID4gYi9kcml2ZXJzL2dwdS9kcm0vdmdlbS92Z2VtX2Rydi5jIGluZGV4IDdhMjA3Y2E1NDdiZS4u YjQ5MWZiMzJjZGRiIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3ZnZW0vdmdlbV9k cnYuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3ZnZW0vdmdlbV9kcnYuYwo+ID4gQEAgLTMy OCw2ICszMjgsOCBAQCBzdGF0aWMgaW50IF9faW5pdCB2Z2VtX2luaXQodm9pZCkKPiA+ICAJCWdv dG8gb3V0Owo+ID4gIAl9Cj4gPiAKPiA+ICsJZHJtX2Rldl9zZXRfdW5pcXVlKGRybSwgInZnZW0i KTsKPiA+ICsKPiA+ICAJcmV0ICA9IGRybV9kZXZfcmVnaXN0ZXIodmdlbV9kZXZpY2UsIDApOwo+ ID4gCj4gPiAgCWlmIChyZXQpCj4gCj4gCj4gTm90IHJlYWxseSBzdXJlIGFib3V0ICJkcm0iIGlu IGRybV9kZXZfc2V0X3VuaXF1ZSgpOgo+IAo+ICAgQ0hLICAgICBpbmNsdWRlL2dlbmVyYXRlZC9j b21waWxlLmgKPiAgIEdaSVAgICAga2VybmVsL2NvbmZpZ19kYXRhLmd6Cj4gICBDSEsgICAgIGtl cm5lbC9jb25maWdfZGF0YS5oCj4gICBDQyAgICAgIGRyaXZlcnMvZ3B1L2RybS92Z2VtL3ZnZW1f ZHJ2Lm8KPiBkcml2ZXJzL2dwdS9kcm0vdmdlbS92Z2VtX2Rydi5jOiBJbiBmdW5jdGlvbiDigJh2 Z2VtX2luaXTigJk6Cj4gZHJpdmVycy9ncHUvZHJtL3ZnZW0vdmdlbV9kcnYuYzozMzE6MjE6IGVy cm9yOiDigJhkcm3igJkgdW5kZWNsYXJlZCAoZmlyc3QgdXNlIGluIAo+IHRoaXMgZnVuY3Rpb24p CgpzL2RybS92Z2VtX2RldmljZS8gLi4uIGNvcHlwYXN0ZSBmYWlsIHdpdGhvdXQgcnVubmluZyBn Y2MuCi1EYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENv cnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754776AbbFWN1E (ORCPT ); Tue, 23 Jun 2015 09:27:04 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:33116 "EHLO mail-wg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752421AbbFWN0z (ORCPT ); Tue, 23 Jun 2015 09:26:55 -0400 Date: Tue, 23 Jun 2015 15:29:41 +0200 From: Daniel Vetter To: Fabio Coatti Cc: Daniel Vetter , Daniel Stone , David Airlie , dri-devel , kernel list Subject: Re: Linux 4.1 WARNING in drm_ioctl.c Message-ID: <20150623132941.GC25769@phenom.ffwll.local> Mail-Followup-To: Fabio Coatti , Daniel Stone , David Airlie , dri-devel , kernel list References: <34169093.qYXxFR1FLt@calvin> <20150623094847.GR25769@phenom.ffwll.local> <3759620.yiBZ6BaR05@calvin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3759620.yiBZ6BaR05@calvin> X-Operating-System: Linux phenom 4.0.0-rc3+ User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 23, 2015 at 12:46:09PM +0200, Fabio Coatti wrote: > In data martedì 23 giugno 2015 11:48:47, Daniel Vetter ha scritto: > > On Tue, Jun 23, 2015 at 08:27:13AM +0100, Daniel Stone wrote: > > > Hi, > > > > > > On 23 June 2015 at 07:39, Daniel Vetter wrote: > > > > Which drm driver are you using? I didn't spot anything in your module > > > > list > > > > but might have missed it. Booting with drm.debug=0xe and grabbing dmesg > > > > will tell us for sure. > > > > > > That'd be vgem. > > > > If so then the below diff should help. > > -Daniel > > diff --git a/drivers/gpu/drm/vgem/vgem_drv.c > > b/drivers/gpu/drm/vgem/vgem_drv.c index 7a207ca547be..b491fb32cddb 100644 > > --- a/drivers/gpu/drm/vgem/vgem_drv.c > > +++ b/drivers/gpu/drm/vgem/vgem_drv.c > > @@ -328,6 +328,8 @@ static int __init vgem_init(void) > > goto out; > > } > > > > + drm_dev_set_unique(drm, "vgem"); > > + > > ret = drm_dev_register(vgem_device, 0); > > > > if (ret) > > > Not really sure about "drm" in drm_dev_set_unique(): > > CHK include/generated/compile.h > GZIP kernel/config_data.gz > CHK kernel/config_data.h > CC drivers/gpu/drm/vgem/vgem_drv.o > drivers/gpu/drm/vgem/vgem_drv.c: In function ‘vgem_init’: > drivers/gpu/drm/vgem/vgem_drv.c:331:21: error: ‘drm’ undeclared (first use in > this function) s/drm/vgem_device/ ... copypaste fail without running gcc. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch