From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7Od1-0000eW-9z for qemu-devel@nongnu.org; Tue, 23 Jun 2015 09:52:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7Ocv-0001Zo-T2 for qemu-devel@nongnu.org; Tue, 23 Jun 2015 09:52:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7Ocv-0001Zc-Oe for qemu-devel@nongnu.org; Tue, 23 Jun 2015 09:52:37 -0400 Date: Tue, 23 Jun 2015 15:52:34 +0200 From: "Michael S. Tsirkin" Message-ID: <20150623135234.GA13199@redhat.com> References: <1433762257-1752411-1-git-send-email-stefanb@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433762257-1752411-1-git-send-email-stefanb@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v4 0/4] Extend TPM support with a QEMU-external TPM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Berger Cc: stefanb@us.ibm.com, qemu-devel@nongnu.org, quan.xu@intel.com On Mon, Jun 08, 2015 at 07:17:33AM -0400, Stefan Berger wrote: > The following series of patches extends TPM support with an > external TPM that offers a Linux CUSE (character device in userspace) > interface. This TPM lets each VM access its own private vTPM. > The CUSE TPM supports suspend/resume and migration. Much > out-of-band functionality necessary to control the CUSE TPM is > implemented using ioctls. So the problem is really review. I feel to judge this adequately I'd have to review cuse code too (since no one else did). And unfortunately I don't have the time to do this anytime soon. As far as I'm concerned, if anyone wants to review and merge these patches, pls go ahead, I have nothing against them. -- MST