From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH 0/2] Revert changes to
 libxl_set_memory_target, unblock 4.6
Date: Tue, 23 Jun 2015 15:19:45 +0100
Message-ID: <20150623141945.GA28647@zion.uk.xensource.com>
References: <1435068984-9163-1-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=609b4a838=wei.liu2@citrix.com>)
	id 1Z7P3n-0005dW-2u
	for xen-devel@lists.xenproject.org; Tue, 23 Jun 2015 14:20:23 +0000
Content-Disposition: inline
In-Reply-To: <1435068984-9163-1-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

CC Jan, author of one of the patches.

On Tue, Jun 23, 2015 at 03:16:22PM +0100, Wei Liu wrote:
> A new memory model that allows QEMU to bump memory behind libxl's back was
> merged a few months ago. We didn't fully understand the repercussions back
> then. Now it breaks migration and becomes blocker of 4.6 release.
> 
> It's better to restore to original behaviour at this stage of the release
> cycle, that would put us in a position no worse than before, so the release is
> unblocked.
> 
> The said function is still racy after reverting these two patches. Making
> domain memory state consistent requires a bit more work. Separate patch(es)
> will be sent out to deal with that problem.
> 
> Wei.
> 
> Wei Liu (2):
>   Revert "libxl: fix "xl mem-set" regression from 0c029c4da2"
>   Revert "libxl_set_memory_target: retain the same maxmem offset on top
>     of the current target"
> 
>  tools/libxc/include/xenctrl.h |  2 +-
>  tools/libxc/xc_domain.c       |  2 +-
>  tools/libxl/libxl.c           | 29 ++++++++++++++++-------------
>  3 files changed, 18 insertions(+), 15 deletions(-)
> 
> -- 
> 1.9.1