From: Mike Crowe <mac@mcrowe.com>
To: Phil Blundell <pb@pbcl.net>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] pixbufcache: Ensure that jpeg-native is available for postinst if necessary
Date: Tue, 23 Jun 2015 16:25:01 +0100 [thread overview]
Message-ID: <20150623152501.GA26456@mcrowe.com> (raw)
In-Reply-To: <1435072346.2483.417.camel@pbcl.net>
On Tuesday 23 June 2015 at 16:12:26 +0100, Phil Blundell wrote:
> On Sat, 2015-06-13 at 19:44 +0100, Mike Crowe wrote:
> > diff --git a/meta/classes/pixbufcache.bbclass b/meta/classes/pixbufcache.bbclass
> > index 9e6ecc8..755a654 100644
> > --- a/meta/classes/pixbufcache.bbclass
> > +++ b/meta/classes/pixbufcache.bbclass
> > @@ -72,6 +72,7 @@ PIXBUFCACHE_SYSROOT_DEPS_class-native = "\
> > glib-2.0-native:do_populate_sysroot_setscene libffi-native:do_populate_sysroot_setscene \
> > libpng-native:do_populate_sysroot_setscene zlib-native:do_populate_sysroot_setscene \
> > harfbuzz-native:do_populate_sysroot_setscene \
> > + ${@bb.utils.contains('PACKAGECONFIG', 'jpeg', 'jpeg-native:do_populate_sysroot_setscene', '', d)} \
>
> I'm not sure this is quite right. PACKAGECONFIG at the point this is
> expanded will be the PACKAGECONFIG for whatever recipe is currently
> inheriting pixbufcache.bbclass, whereas I think what you really need
> here is the PACKAGECONFIG that gdk-pixbuf itself was built with. Or,
> er, something.
The problem I was seeing was with gdk-pixbuf itself so it sounds like I
need to add the dependency only when '${BPN}' == 'gdk-pixbuf' itself. I'll
have a go at that.
Thanks.
Mike.
next prev parent reply other threads:[~2015-06-23 15:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-13 18:44 [PATCH] pixbufcache: Ensure that jpeg-native is available for postinst if necessary Mike Crowe
2015-06-13 18:46 ` Mike Crowe
2015-06-23 15:12 ` Phil Blundell
2015-06-23 15:20 ` Richard Purdie
2015-06-23 18:46 ` Mike Crowe
2015-06-23 15:25 ` Mike Crowe [this message]
2015-06-23 16:56 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623152501.GA26456@mcrowe.com \
--to=mac@mcrowe.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=pb@pbcl.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.