All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	Benjamin LaHaise <bcrl@kvack.org>,
	Hugh Dickins <hughd@google.com>, Jeff Moyer <jmoyer@redhat.com>,
	Kirill Shutemov <kirill.shutemov@linux.intel.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andy Lutomirski <luto@kernel.org>,
	Pavel Emelyanov <xemul@parallels.com>
Subject: [PATCH 0/1] mm: move ->mremap() from file_operations to vm_operations_struct
Date: Tue, 23 Jun 2015 20:02:25 +0200	[thread overview]
Message-ID: <20150623180225.GA12882@redhat.com> (raw)

On 06/22, Andy Lutomirski wrote:
>
> On Mon, Jun 22, 2015 at 5:47 PM, Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > I never understood why ->mremap() lives in file_operations, not in
> > vm_operations_struct. To me vma->vm_file->f_op in move_vma() just
> > looks strange, vma->vm_ops->mremap(new_vma) looks "obviously better".
> >
> > And afaics more useful. CRIU remaps vdso, but this does not update
> > mm->context.vdso. OK, probably this does not matter currently, CRIU
> > can't c/r the compat tasks, and 64-bit apps do not use context.vdso.
> > Afaics. Still, I think we might want to have special_mapping_remap()
> > and we can't do this because ->vm_file == NULL.
>
> I would like this.  Then I could clean up and resubmit my patch to
> keep context.vdso up to date.

Cough... where can I find this patch ? ;)

> Oleg, can you let me know what patch, if any, I should be reviewing?

This one, it looks really trivial. And of course I will appreciate it
if you can review the special_mapping_fault() fixes.

The change in move_vma() textually depends on another patch I sent,

	[PATCH 1/4] mremap: don't leak new_vma if f_op->mremap() fails
	http://marc.info/?l=linux-kernel&m=143475603713622

Oleg.


             reply	other threads:[~2015-06-23 18:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 18:02 Oleg Nesterov [this message]
2015-06-23 18:02 ` [PATCH 1/1] mm: move ->mremap() from file_operations to vm_operations_struct Oleg Nesterov
2015-06-23 18:19   ` Kirill A. Shutemov
2015-06-23 18:26     ` Oleg Nesterov
2015-06-24 15:49       ` Oleg Nesterov
2015-06-24 19:23         ` Kirill A. Shutemov
2015-06-25 20:43           ` Oleg Nesterov
2015-06-23 21:01   ` Andy Lutomirski
2015-06-23 21:11   ` Pavel Emelyanov
2015-06-23 20:59 ` [PATCH 0/1] " Andy Lutomirski
2015-06-24 13:53   ` Oleg Nesterov
2015-06-25 20:45 ` [PATCH v2 1/1] " Oleg Nesterov
2015-06-25 22:08   ` Kirill A. Shutemov
2015-06-25 23:41     ` Oleg Nesterov
2015-06-26 12:21   ` Pavel Emelyanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150623180225.GA12882@redhat.com \
    --to=oleg@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bcrl@kvack.org \
    --cc=hughd@google.com \
    --cc=jmoyer@redhat.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=luto@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.