From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41714)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Z7Xin-0008BK-Iy
	for qemu-devel@nongnu.org; Tue, 23 Jun 2015 19:35:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Z7Xim-0002RR-GM
	for qemu-devel@nongnu.org; Tue, 23 Jun 2015 19:35:17 -0400
Received: from [2001:bc8:30d7:101::1] (port=41750 helo=hall.aurel32.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Z7Xim-0002RJ-An
	for qemu-devel@nongnu.org; Tue, 23 Jun 2015 19:35:16 -0400
Date: Wed, 24 Jun 2015 01:35:14 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20150623233514.GC11474@aurel32.net>
References: <1435073928-21830-1-git-send-email-yongbok.kim@imgtec.com>
	<1435073928-21830-4-git-send-email-yongbok.kim@imgtec.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1435073928-21830-4-git-send-email-yongbok.kim@imgtec.com>
Subject: Re: [Qemu-devel] [PATCH v3 03/15] target-mips: remove an unused
	argument
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yongbok Kim <yongbok.kim@imgtec.com>
Cc: leon.alrae@imgtec.com, qemu-devel@nongnu.org

On 2015-06-23 16:38, Yongbok Kim wrote:
> remove an unused argument from decode_micromips32_opc()
> 
> Signed-off-by: Yongbok Kim <yongbok.kim@imgtec.com>
> Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>
> ---
>  target-mips/translate.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/target-mips/translate.c b/target-mips/translate.c
> index 963ff8b..83dfb2f 100644
> --- a/target-mips/translate.c
> +++ b/target-mips/translate.c
> @@ -13404,8 +13404,7 @@ static void gen_pool32fxf(DisasContext *ctx, int rt, int rs)
>      }
>  }
>  
> -static void decode_micromips32_opc (CPUMIPSState *env, DisasContext *ctx,
> -                                    uint16_t insn_hw1)
> +static void decode_micromips32_opc(CPUMIPSState *env, DisasContext *ctx)
>  {
>      int32_t offset;
>      uint16_t insn;
> @@ -14448,7 +14447,7 @@ static int decode_micromips_opc (CPUMIPSState *env, DisasContext *ctx)
>          generate_exception(ctx, EXCP_RI);
>          break;
>      default:
> -        decode_micromips32_opc (env, ctx, op);
> +        decode_micromips32_opc(env, ctx);
>          return 4;
>      }

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net