All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Christian Hartmann <cornogle@googlemail.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 1/1] SPI : spi-pxa2xx : fix spi init of	WM510205 codec via ACPI (resend)
Date: Wed, 24 Jun 2015 09:23:41 +0100	[thread overview]
Message-ID: <20150624082341.GA6321@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAKor6TeUOa6GdcscTWziw_q3GXj4wNh=8jnQigQfS7Se8iL+Nw@mail.gmail.com>

On Tue, Jun 23, 2015 at 01:16:54PM +0200, Christian Hartmann wrote:
> Hello,
> 
> I have one patch that enables the spi initialization of the WM510205 audio codec
> Without the patch, this message indicates that the codec chip fails
> with the current chipselect number in spi-pxa2xx:
> 
> 
> [ 0.296256] pxa2xx-spi 80860F0E:00: cs1 >= max 1
> [ 0.296270] spi_master spi32766: failed to add SPI device
> WM510205:00 from ACPI
> 
> So raise num_chipselect by one to enable the codec. The WM510202 is on
> chipselect = 1.
> 
> With the patch applied I got in dmesg now:
> 
> [    6.056829] pxa2xx-spi 80860F0E:00: no DMA channels available, using PIO
> [    6.067035] pxa2xx-spi 80860F0E:00: registered master spi32766 (dynamic)
> [    6.067214] spi spi-WM510205:00: 8333333 Hz actual, PIO
> [    6.067221] spi spi-WM510205:00: setup mode 0, 8 bits/w, 8000000 Hz max --> 0
> [    6.067287] pxa2xx-spi 80860F0E:00: registered child spi-WM510205:00
> 
> Signed-off-by: Christian Hartmann <cornogle@googlemail.com>
> ---

You need to send the patch to the right people, you definitely
need to send the patch to Mark Brown as he is maintainer for the
SPI subsystem so will be the person who applies your patch.

Additionally, you probably want to try to look for if there are
any active people on this particular spi driver and include them.
The script get_maintainer.pl is a good starting point although it
often includes too few people without the git option and too many
with the git option.

Thanks,
Charles

      reply	other threads:[~2015-06-24  8:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 11:16 [PATCH 1/1] SPI : spi-pxa2xx : fix spi init of WM510205 codec via ACPI (resend) Christian Hartmann
2015-06-24  8:23 ` Charles Keepax [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150624082341.GA6321@opensource.wolfsonmicro.com \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=cornogle@googlemail.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.