All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
Cc: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>,
	bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
	balbi-l0cyMroinI0@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
	gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	nsekhar-l0cyMroinI0@public.gmane.org
Subject: Re: [PATCH 08/17] ARM: dts: dra7: Add dt node for the sycon pcie
Date: Wed, 24 Jun 2015 05:49:57 -0700	[thread overview]
Message-ID: <20150624124956.GH4156@atomide.com> (raw)
In-Reply-To: <20150624151931.87252315d0e61ddfd55c4724-l0cyMroinI0@public.gmane.org>

* Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org> [150624 05:21]:
> On Wed, 24 Jun 2015 05:09:39 -0700
> Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> wrote:
> > 
> > My take is we should only use regmap for the scm_conf area
> > in general.
> 
> +1
> 
> should we get rid of dra7_ctrl_core and dra7_ctrl_general?
> or move them to scm node?

Well at least move them. And if there are clear dedicated
register ranges there claimed only by a single device driver,
then those drivers should be just regular loadable driver
modules doing of_ioremap on the range. And in that case they
can be removed.

We have examples of both in dra7.dtsi, pbias_regulator using
the scm_conf via syscon, and then dra7_pmx_core ioremapping
a dedicated register range. So unless there are other messy
register ranges like the scm_conf area then there should not
be need for other syscon areas.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/17] ARM: dts: dra7: Add dt node for the sycon pcie
Date: Wed, 24 Jun 2015 05:49:57 -0700	[thread overview]
Message-ID: <20150624124956.GH4156@atomide.com> (raw)
In-Reply-To: <20150624151931.87252315d0e61ddfd55c4724@ti.com>

* Roger Quadros <rogerq@ti.com> [150624 05:21]:
> On Wed, 24 Jun 2015 05:09:39 -0700
> Tony Lindgren <tony@atomide.com> wrote:
> > 
> > My take is we should only use regmap for the scm_conf area
> > in general.
> 
> +1
> 
> should we get rid of dra7_ctrl_core and dra7_ctrl_general?
> or move them to scm node?

Well at least move them. And if there are clear dedicated
register ranges there claimed only by a single device driver,
then those drivers should be just regular loadable driver
modules doing of_ioremap on the range. And in that case they
can be removed.

We have examples of both in dra7.dtsi, pbias_regulator using
the scm_conf via syscon, and then dra7_pmx_core ioremapping
a dedicated register range. So unless there are other messy
register ranges like the scm_conf area then there should not
be need for other syscon areas.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Roger Quadros <rogerq@ti.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	bcousson@baylibre.com, balbi@ti.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
	robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	linux@arm.linux.org.uk, gregkh@linuxfoundation.org,
	nsekhar@ti.com
Subject: Re: [PATCH 08/17] ARM: dts: dra7: Add dt node for the sycon pcie
Date: Wed, 24 Jun 2015 05:49:57 -0700	[thread overview]
Message-ID: <20150624124956.GH4156@atomide.com> (raw)
In-Reply-To: <20150624151931.87252315d0e61ddfd55c4724@ti.com>

* Roger Quadros <rogerq@ti.com> [150624 05:21]:
> On Wed, 24 Jun 2015 05:09:39 -0700
> Tony Lindgren <tony@atomide.com> wrote:
> > 
> > My take is we should only use regmap for the scm_conf area
> > in general.
> 
> +1
> 
> should we get rid of dra7_ctrl_core and dra7_ctrl_general?
> or move them to scm node?

Well at least move them. And if there are clear dedicated
register ranges there claimed only by a single device driver,
then those drivers should be just regular loadable driver
modules doing of_ioremap on the range. And in that case they
can be removed.

We have examples of both in dra7.dtsi, pbias_regulator using
the scm_conf via syscon, and then dra7_pmx_core ioremapping
a dedicated register range. So unless there are other messy
register ranges like the scm_conf area then there should not
be need for other syscon areas.

Regards,

Tony

  parent reply	other threads:[~2015-06-24 12:49 UTC|newest]

Thread overview: 150+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 11:58 [PATCH 00/17] Deprecate phy-omap-control and use SYSCON Kishon Vijay Abraham I
2015-06-23 11:58 ` Kishon Vijay Abraham I
2015-06-23 11:58 ` Kishon Vijay Abraham I
2015-06-23 11:58 ` [PATCH 01/17] phy: ti-pipe3: use ti_pipe3_power_off to power off the PHY during probe Kishon Vijay Abraham I
2015-06-23 11:58   ` Kishon Vijay Abraham I
2015-06-23 11:58   ` Kishon Vijay Abraham I
2015-06-23 14:47   ` Roger Quadros
2015-06-23 14:47     ` Roger Quadros
2015-06-23 14:47     ` Roger Quadros
2015-06-23 11:58 ` [PATCH 02/17] phy: ti-pipe3: use *syscon* framework to power on/off the PHY Kishon Vijay Abraham I
2015-06-23 11:58   ` Kishon Vijay Abraham I
2015-06-23 11:58   ` Kishon Vijay Abraham I
     [not found]   ` <1435060743-5511-3-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2015-06-23 14:53     ` Roger Quadros
2015-06-23 14:53       ` Roger Quadros
2015-06-23 14:53       ` Roger Quadros
     [not found]       ` <20150623175355.d80c1d6626439fbb6c26169c-l0cyMroinI0@public.gmane.org>
2015-06-24 11:26         ` Kishon Vijay Abraham I
2015-06-24 11:26           ` Kishon Vijay Abraham I
2015-06-24 11:26           ` Kishon Vijay Abraham I
2015-06-23 11:58 ` [PATCH 03/17] phy: ti-pipe3: use *syscon* framework to set PCS value of " Kishon Vijay Abraham I
2015-06-23 11:58   ` Kishon Vijay Abraham I
2015-06-23 11:58   ` Kishon Vijay Abraham I
     [not found]   ` <1435060743-5511-4-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2015-06-24 10:34     ` Roger Quadros
2015-06-24 10:34       ` Roger Quadros
2015-06-24 10:34       ` Roger Quadros
2015-06-24 13:16       ` Kishon Vijay Abraham I
2015-06-24 13:16         ` Kishon Vijay Abraham I
2015-06-24 13:16         ` Kishon Vijay Abraham I
     [not found]         ` <558AAD98.1090602-l0cyMroinI0@public.gmane.org>
2015-06-24 13:48           ` Roger Quadros
2015-06-24 13:48             ` Roger Quadros
2015-06-24 13:48             ` Roger Quadros
2015-06-23 11:58 ` [PATCH 04/17] phy: omap-usb2: use omap_usb_power_off to power off the PHY during probe Kishon Vijay Abraham I
2015-06-23 11:58   ` Kishon Vijay Abraham I
2015-06-23 11:58   ` Kishon Vijay Abraham I
     [not found]   ` <1435060743-5511-5-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2015-06-24 10:58     ` Roger Quadros
2015-06-24 10:58       ` Roger Quadros
2015-06-24 10:58       ` Roger Quadros
2015-06-23 11:58 ` [PATCH 07/17] usb: musb: omap2430: use *syscon* framework to write to mailbox register Kishon Vijay Abraham I
2015-06-23 11:58   ` Kishon Vijay Abraham I
2015-06-23 11:58   ` Kishon Vijay Abraham I
2015-06-24 11:39   ` Roger Quadros
2015-06-24 11:39     ` Roger Quadros
2015-06-24 11:39     ` Roger Quadros
2015-06-24 13:21     ` Kishon Vijay Abraham I
2015-06-24 13:21       ` Kishon Vijay Abraham I
2015-06-24 13:21       ` Kishon Vijay Abraham I
     [not found]   ` <1435060743-5511-8-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2015-06-24 11:49     ` Tony Lindgren
2015-06-24 11:49       ` Tony Lindgren
2015-06-24 11:49       ` Tony Lindgren
     [not found]       ` <20150624114907.GF4156-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-06-24 13:06         ` Kishon Vijay Abraham I
2015-06-24 13:06           ` Kishon Vijay Abraham I
2015-06-24 13:06           ` Kishon Vijay Abraham I
2015-06-23 11:58 ` [PATCH 08/17] ARM: dts: dra7: Add dt node for the sycon pcie Kishon Vijay Abraham I
2015-06-23 11:58   ` Kishon Vijay Abraham I
2015-06-23 11:58   ` Kishon Vijay Abraham I
     [not found]   ` <1435060743-5511-9-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2015-06-24 11:50     ` Roger Quadros
2015-06-24 11:50       ` Roger Quadros
2015-06-24 11:50       ` Roger Quadros
2015-06-24 11:56       ` Roger Quadros
2015-06-24 11:56         ` Roger Quadros
2015-06-24 11:56         ` Roger Quadros
     [not found]         ` <20150624145617.e5248d466fe5b2e0eb1ca087-l0cyMroinI0@public.gmane.org>
2015-06-24 12:09           ` Tony Lindgren
2015-06-24 12:09             ` Tony Lindgren
2015-06-24 12:09             ` Tony Lindgren
     [not found]             ` <20150624120938.GG4156-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-06-24 12:19               ` Roger Quadros
2015-06-24 12:19                 ` Roger Quadros
2015-06-24 12:19                 ` Roger Quadros
     [not found]                 ` <20150624151931.87252315d0e61ddfd55c4724-l0cyMroinI0@public.gmane.org>
2015-06-24 12:49                   ` Tony Lindgren [this message]
2015-06-24 12:49                     ` Tony Lindgren
2015-06-24 12:49                     ` Tony Lindgren
2015-06-24 13:30           ` Kishon Vijay Abraham I
2015-06-24 13:30             ` Kishon Vijay Abraham I
2015-06-24 13:30             ` Kishon Vijay Abraham I
2015-06-24 13:29       ` Kishon Vijay Abraham I
2015-06-24 13:29         ` Kishon Vijay Abraham I
2015-06-24 13:29         ` Kishon Vijay Abraham I
     [not found] ` <1435060743-5511-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2015-06-23 11:58   ` [PATCH 05/17] phy: omap-usb2: Add a new compatible string for USB2 PHY2 Kishon Vijay Abraham I
2015-06-23 11:58     ` Kishon Vijay Abraham I
2015-06-23 11:58     ` Kishon Vijay Abraham I
2015-06-24 11:03     ` Roger Quadros
2015-06-24 11:03       ` Roger Quadros
2015-06-24 11:03       ` Roger Quadros
     [not found]       ` <20150624140354.c3c1b0fc24dc37eae5097b4c-l0cyMroinI0@public.gmane.org>
2015-06-24 13:21         ` Kishon Vijay Abraham I
2015-06-24 13:21           ` Kishon Vijay Abraham I
2015-06-24 13:21           ` Kishon Vijay Abraham I
2015-06-23 11:58   ` [PATCH 06/17] phy: omap-usb2: use *syscon* framework to power on/off the PHY Kishon Vijay Abraham I
2015-06-23 11:58     ` Kishon Vijay Abraham I
2015-06-23 11:58     ` Kishon Vijay Abraham I
     [not found]     ` <1435060743-5511-7-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2015-06-24 11:33       ` Roger Quadros
2015-06-24 11:33         ` Roger Quadros
2015-06-24 11:33         ` Roger Quadros
2015-06-24 12:59         ` Kishon Vijay Abraham I
2015-06-24 12:59           ` Kishon Vijay Abraham I
2015-06-24 12:59           ` Kishon Vijay Abraham I
2015-06-23 11:58   ` [PATCH 09/17] ARM: dts: dra7: Use "syscon-phy-power" instead of "ctrl-module" in SATA PHY node Kishon Vijay Abraham I
2015-06-23 11:58     ` Kishon Vijay Abraham I
2015-06-23 11:58     ` Kishon Vijay Abraham I
2015-06-24 12:06     ` Roger Quadros
2015-06-24 12:06       ` Roger Quadros
2015-06-24 12:06       ` Roger Quadros
     [not found]       ` <20150624150602.0e73fc8f9dda1624f22059db-l0cyMroinI0@public.gmane.org>
2015-06-24 12:12         ` Roger Quadros
2015-06-24 12:12           ` Roger Quadros
2015-06-24 12:12           ` Roger Quadros
     [not found]           ` <20150624151257.fe5f1594db1afe4c1da8027d-l0cyMroinI0@public.gmane.org>
2015-06-24 13:31             ` Kishon Vijay Abraham I
2015-06-24 13:31               ` Kishon Vijay Abraham I
2015-06-24 13:31               ` Kishon Vijay Abraham I
2015-06-23 11:58   ` [PATCH 10/17] ARM: dts: dra7: Use "syscon-phy-power" and "syscon-pcs" in PCIe " Kishon Vijay Abraham I
2015-06-23 11:58     ` Kishon Vijay Abraham I
2015-06-23 11:58     ` Kishon Vijay Abraham I
2015-06-23 11:58   ` [PATCH 11/17] ARM: dts: dra7: Use "ti,dra7x-usb2-phy2" compatible string for USB2 PHY2 Kishon Vijay Abraham I
2015-06-23 11:58     ` Kishon Vijay Abraham I
2015-06-23 11:58     ` [PATCH 11/17] ARM: dts: dra7: Use "ti, dra7x-usb2-phy2" " Kishon Vijay Abraham I
     [not found]     ` <1435060743-5511-12-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2015-06-24 12:07       ` [PATCH 11/17] ARM: dts: dra7: Use "ti,dra7x-usb2-phy2" " Roger Quadros
2015-06-24 12:07         ` Roger Quadros
2015-06-24 12:07         ` Roger Quadros
     [not found]         ` <20150624150750.9435096c85253cfe528ebbc3-l0cyMroinI0@public.gmane.org>
2015-06-24 13:10           ` Kishon Vijay Abraham I
2015-06-24 13:10             ` Kishon Vijay Abraham I
2015-06-24 13:10             ` [PATCH 11/17] ARM: dts: dra7: Use "ti, dra7x-usb2-phy2" " Kishon Vijay Abraham I
     [not found]             ` <558AAC47.2070305-l0cyMroinI0@public.gmane.org>
2015-06-24 13:50               ` [PATCH 11/17] ARM: dts: dra7: Use "ti,dra7x-usb2-phy2" " Roger Quadros
2015-06-24 13:50                 ` Roger Quadros
2015-06-24 13:50                 ` Roger Quadros
2015-06-23 11:58   ` [PATCH 13/17] ARM: dts: am4372: Use "syscon-phy-power" instead of "ctrl-module" in USB PHY node Kishon Vijay Abraham I
2015-06-23 11:58     ` Kishon Vijay Abraham I
2015-06-23 11:58     ` Kishon Vijay Abraham I
2015-06-23 11:58   ` [PATCH 14/17] ARM: dts: OMAP5: " Kishon Vijay Abraham I
2015-06-23 11:58     ` Kishon Vijay Abraham I
2015-06-23 11:58     ` Kishon Vijay Abraham I
2015-06-23 11:59   ` [PATCH 16/17] ARM: dts: omap4: " Kishon Vijay Abraham I
2015-06-23 11:59     ` Kishon Vijay Abraham I
2015-06-23 11:59     ` Kishon Vijay Abraham I
2015-06-23 11:59   ` [PATCH 17/17] ARM: dts: omap4: Use "syscon-otghs" instead of "ctrl-module" in USB node Kishon Vijay Abraham I
2015-06-23 11:59     ` Kishon Vijay Abraham I
2015-06-23 11:59     ` Kishon Vijay Abraham I
     [not found]     ` <1435060743-5511-18-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2015-06-24 10:41       ` Tony Lindgren
2015-06-24 10:41         ` Tony Lindgren
2015-06-24 10:41         ` Tony Lindgren
2015-06-24 11:21         ` Kishon Vijay Abraham I
2015-06-24 11:21           ` Kishon Vijay Abraham I
2015-06-24 11:21           ` Kishon Vijay Abraham I
     [not found]           ` <558A92A5.5070506-l0cyMroinI0@public.gmane.org>
2015-06-24 11:46             ` Tony Lindgren
2015-06-24 11:46               ` Tony Lindgren
2015-06-24 11:46               ` Tony Lindgren
2015-06-24 12:02         ` Roger Quadros
2015-06-24 12:02           ` Roger Quadros
2015-06-24 12:02           ` Roger Quadros
2015-06-23 11:58 ` [PATCH 12/17] ARM: dts: dra7: Use "syscon-phy-power" instead of "ctrl-module" in USB PHY node Kishon Vijay Abraham I
2015-06-23 11:58   ` Kishon Vijay Abraham I
2015-06-23 11:58   ` Kishon Vijay Abraham I
2015-06-23 11:59 ` [PATCH 15/17] ARM: dts: OMAP5: Use "syscon-phy-power" instead of "ctrl-module" in SATA " Kishon Vijay Abraham I
2015-06-23 11:59   ` Kishon Vijay Abraham I
2015-06-23 11:59   ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150624124956.GH4156@atomide.com \
    --to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=kishon-l0cyMroinI0@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=nsekhar-l0cyMroinI0@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=rogerq-l0cyMroinI0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.