From: "mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org" <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: "De Marchi,
Lucas" <lucas.demarchi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "christian.ruppert-Yycd8EPnGM5BDgjK7y7TUQ@public.gmane.org"
<christian.ruppert-Yycd8EPnGM5BDgjK7y7TUQ@public.gmane.org>,
"lucas.de.marchi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<lucas.de.marchi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org"
<wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
"Mello,
Fabio" <fabio.mello-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org"
<jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
"christian.ruppert-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org"
<christian.ruppert-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] i2c: designware: use enable on resume instead initialization
Date: Wed, 24 Jun 2015 16:18:30 +0300 [thread overview]
Message-ID: <20150624131830.GF827@lahna.fi.intel.com> (raw)
In-Reply-To: <1435150578.1075.5.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Wed, Jun 24, 2015 at 12:56:19PM +0000, De Marchi, Lucas wrote:
> Yeah, but it would be bad to ignore the problem as well. The way it is now
> kills any possibility of using DW controller for reading sensors like
> gyroscope, accelerometer, barometer that have higher sampling rate etc. I'll
> try to come up with a new patch but since I can't reproduce the problem here
> it'd be good to know if there's any means for me to test. What do you think
> that could be done? Maybe putting the controller to sleep only in case of
> errors?
Instead of disabling the adapter after each transfer, I wonder if it is
enough if we just mask all interrupts? That should also prevent the
interrupt loop Christian is seeing on his hardware.
WARNING: multiple messages have this Message-ID (diff)
From: "mika.westerberg@linux.intel.com" <mika.westerberg@linux.intel.com>
To: "De Marchi, Lucas" <lucas.demarchi@intel.com>
Cc: "christian.ruppert@alitech.com" <christian.ruppert@alitech.com>,
"lucas.de.marchi@gmail.com" <lucas.de.marchi@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"wsa@the-dreams.de" <wsa@the-dreams.de>,
"Mello, Fabio" <fabio.mello@intel.com>,
"jarkko.nikula@linux.intel.com" <jarkko.nikula@linux.intel.com>,
"christian.ruppert@abilis.com" <christian.ruppert@abilis.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] i2c: designware: use enable on resume instead initialization
Date: Wed, 24 Jun 2015 16:18:30 +0300 [thread overview]
Message-ID: <20150624131830.GF827@lahna.fi.intel.com> (raw)
In-Reply-To: <1435150578.1075.5.camel@intel.com>
On Wed, Jun 24, 2015 at 12:56:19PM +0000, De Marchi, Lucas wrote:
> Yeah, but it would be bad to ignore the problem as well. The way it is now
> kills any possibility of using DW controller for reading sensors like
> gyroscope, accelerometer, barometer that have higher sampling rate etc. I'll
> try to come up with a new patch but since I can't reproduce the problem here
> it'd be good to know if there's any means for me to test. What do you think
> that could be done? Maybe putting the controller to sleep only in case of
> errors?
Instead of disabling the adapter after each transfer, I wonder if it is
enough if we just mask all interrupts? That should also prevent the
interrupt loop Christian is seeing on his hardware.
next prev parent reply other threads:[~2015-06-24 13:18 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 17:50 [PATCH] i2c: designware: use enable on resume instead initialization lucas.de.marchi-Re5JQEeQqe8AvxtiuMwx3w
2015-06-08 17:50 ` lucas.de.marchi
[not found] ` <1433785828-4100-1-git-send-email-lucas.de.marchi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-06-09 8:51 ` Mika Westerberg
2015-06-09 8:51 ` Mika Westerberg
[not found] ` <20150609085146.GD1478-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-06-09 18:29 ` Lucas De Marchi
2015-06-09 18:29 ` Lucas De Marchi
[not found] ` <CAKi4VAJwD45VbWuCHegfkB-tbgvgza52-cgVNF4AxF8NCuYyRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-10 7:07 ` Mika Westerberg
2015-06-10 7:07 ` Mika Westerberg
[not found] ` <OF847FFF39.1FF5F96A-ONC1257E60.00506AFD-C1257E60.0052A8CE@alitech.com>
[not found] ` <OF847FFF39.1FF5F96A-ONC1257E60.00506AFD-C1257E60.0052A8CE-Yycd8EPnGM5BDgjK7y7TUQ@public.gmane.org>
2015-06-11 9:38 ` Mika Westerberg
2015-06-11 9:38 ` Mika Westerberg
2015-06-11 14:48 ` Lucas De Marchi
2015-06-11 14:48 ` Lucas De Marchi
[not found] ` <OF847FFF39.1FF5F96A-ONC1257E60.00506AFD-C1257E60.0052A8CE@LocalDomain>
2015-06-23 16:45 ` christian.ruppert-Yycd8EPnGM5BDgjK7y7TUQ
2015-06-23 16:45 ` christian.ruppert
[not found] ` <OFB47A681B.5488F019-ONC1257E6D.005A6CD2-C1257E6D.005BD52F-Yycd8EPnGM5BDgjK7y7TUQ@public.gmane.org>
2015-06-23 17:02 ` Lucas De Marchi
2015-06-23 17:02 ` Lucas De Marchi
[not found] ` <CAKi4VA+t3d-XoqDiL9ez+9qDR_ndgGnAOhkpZsJyJ2tMjfCYLA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-24 7:36 ` christian.ruppert-Yycd8EPnGM5BDgjK7y7TUQ
2015-06-24 7:36 ` christian.ruppert
[not found] ` <OFB918064C.F72245F4-ONC1257E6E.00287EC7-C1257E6E.00299EF2-Yycd8EPnGM5BDgjK7y7TUQ@public.gmane.org>
2015-06-24 11:27 ` Mika Westerberg
2015-06-24 11:27 ` Mika Westerberg
[not found] ` <20150624112723.GE827-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-06-24 12:56 ` De Marchi, Lucas
2015-06-24 12:56 ` De Marchi, Lucas
[not found] ` <1435150578.1075.5.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-06-24 13:18 ` mika.westerberg-VuQAYsv1563Yd54FQh9/CA [this message]
2015-06-24 13:18 ` mika.westerberg
2015-06-24 14:06 ` christian.ruppert-Yycd8EPnGM5BDgjK7y7TUQ
2015-06-24 14:06 ` christian.ruppert
2015-06-10 7:55 ` Mika Westerberg
2015-06-10 7:55 ` Mika Westerberg
[not found] ` <20150610075555.GO1478-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-06-12 22:45 ` Lucas De Marchi
2015-06-12 22:45 ` Lucas De Marchi
2015-06-15 9:29 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150624131830.GF827@lahna.fi.intel.com \
--to=mika.westerberg-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=christian.ruppert-Yycd8EPnGM5BDgjK7y7TUQ@public.gmane.org \
--cc=christian.ruppert-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org \
--cc=fabio.mello-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lucas.de.marchi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=lucas.demarchi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.