From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57799)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1Z7lZj-0006cE-HM
	for qemu-devel@nongnu.org; Wed, 24 Jun 2015 10:22:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1Z7lZe-0004Iz-GQ
	for qemu-devel@nongnu.org; Wed, 24 Jun 2015 10:22:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52327)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1Z7lZe-0004Iv-B1
	for qemu-devel@nongnu.org; Wed, 24 Jun 2015 10:22:46 -0400
Date: Wed, 24 Jun 2015 15:22:44 +0100
From: "Richard W.M. Jones" <rjones@redhat.com>
Message-ID: <20150624142243.GX29283@redhat.com>
References: <1435095289-14342-2-git-send-email-makovick@gmail.com>
	<1435122325-13478-1-git-send-email-makovick@gmail.com>
	<558ABB79.20202@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <558ABB79.20202@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] qcow2: Handle EAGAIN returned from
 update_refcount
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cole Robinson <crobinso@redhat.com>
Cc: =?utf-8?Q?Jind=C5=99ich_Makovi=C4=8Dka?= <makovick@gmail.com>, qemu-devel@nongnu.org


On Wed, Jun 24, 2015 at 10:15:21AM -0400, Cole Robinson wrote:
> On 06/24/2015 01:05 AM, Jind=C5=99ich Makovi=C4=8Dka wrote:
> > Fixes a crash during image compression
> >=20
> > Signed-off-by: Jind=C5=99ich Makovi=C4=8Dka <makovick@gmail.com>
> > ---
> >  block/qcow2-refcount.c | 22 ++++++++++++----------
> >  1 file changed, 12 insertions(+), 10 deletions(-)
> >=20
>=20
> Rich Jones already confirmed that this patch fixes a bug he can reliabl=
y
> reproduce:
>=20
> https://bugzilla.redhat.com/show_bug.cgi?id=3D1214855

Confirmed.  You can add

  Tested-by: Richard W.M. Jones <rjones@redhat.com>

to this patch.

Also note that if you view the patch without whitespace changes
(eg. git diff -b) then it's actually quite simple.

Rich.

--=20
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rj=
ones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/