All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: airlied@gmail.com
Cc: dri-devel@lists.freedesktop.org
Subject: re: Add virtio gpu driver.
Date: Wed, 24 Jun 2015 17:29:08 +0300	[thread overview]
Message-ID: <20150624142908.GC1702@mwanda> (raw)

Hello Dave Airlie,

The patch dc5698e80cf7: "Add virtio gpu driver." from Sep 9, 2013,
leads to the following static checker warning:

	drivers/gpu/drm/virtio/virtgpu_vq.c:119 virtio_gpu_free_vbufs()
	warn: inconsistent returns 'spin_lock:&vgdev->free_vbufs_lock'.

drivers/gpu/drm/virtio/virtgpu_vq.c
   102  void virtio_gpu_free_vbufs(struct virtio_gpu_device *vgdev)
   103  {
   104          struct virtio_gpu_vbuffer *vbuf;
   105          int i, count = 0;
   106  
   107          count += virtqueue_get_vring_size(vgdev->ctrlq.vq);
   108          count += virtqueue_get_vring_size(vgdev->cursorq.vq);
   109  
   110          spin_lock(&vgdev->free_vbufs_lock);
   111          for (i = 0; i < count; i++) {
   112                  if (WARN_ON(list_empty(&vgdev->free_vbufs)))
   113                          return;
                                ^^^^^^^
Returning with lock held.

   114                  vbuf = list_first_entry(&vgdev->free_vbufs,
   115                                          struct virtio_gpu_vbuffer, list);
   116                  list_del(&vbuf->list);
   117          }
   118          spin_unlock(&vgdev->free_vbufs_lock);
   119          kfree(vgdev->vbufs);
   120  }

regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

                 reply	other threads:[~2015-06-24 14:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150624142908.GC1702@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.