All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Taku Izumi <izumi.taku@jp.fujitsu.com>
Cc: brouer@redhat.com, netdev@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, dvhart@infradead.org,
	rkhan@redhat.com, alexander.h.duyck@redhat.com,
	linux-acpi@vger.kernel.org, joe@perches.com,
	yasu.isimatu@gmail.com
Subject: Re: [PATCH v2 00/22] FUJITSU Extended Socket network device driver
Date: Wed, 24 Jun 2015 15:41:13 +0200	[thread overview]
Message-ID: <20150624154113.4b41db79@redhat.com> (raw)
In-Reply-To: <1435114351-6961-1-git-send-email-izumi.taku@jp.fujitsu.com>

On Wed, 24 Jun 2015 11:52:31 +0900
Taku Izumi <izumi.taku@jp.fujitsu.com> wrote:

> This patchsets adds FUJITSU Extended Socket network device driver.
> Extended Socket network device is a shared memory based high-speed network
> interface between Extended Partitions of PRIMEQUEST 2000 E2 series.
> 
> You can get some information about Extended Partition and Extended
> Socket by referring the following manual.
> 
> http://globalsp.ts.fujitsu.com/dmsp/Publications/public/CA92344-0537.pdf
>   3.2.1 Extended Partitioning
>   3.2.2 Extended Socket
> 
> v1 -> v2:
>   - Location change
>     drivers/platform/x86 => driver/net

Could/should this driver be placed under driver/net/ethernet/fujitsu ??

You are using Ethernet addresses but they are kind of special, always
02:00:00:00:00:xx which is hard-coded... maybe I misunderstand the
code/hw and it is not Ethernet?

[...]
>  drivers/net/fjes/Makefile       |   31 +
>  drivers/net/fjes/fjes.h         |   77 +++
>  drivers/net/fjes/fjes_ethtool.c |  135 ++++
>  drivers/net/fjes/fjes_hw.c      | 1122 +++++++++++++++++++++++++++++++
>  drivers/net/fjes/fjes_hw.h      |  333 ++++++++++
>  drivers/net/fjes/fjes_main.c    | 1397 +++++++++++++++++++++++++++++++++++++++
>  drivers/net/fjes/fjes_regs.h    |  142 ++++
>  9 files changed, 3246 insertions(+)
>  create mode 100644 drivers/net/fjes/Makefile
>  create mode 100644 drivers/net/fjes/fjes.h
>  create mode 100644 drivers/net/fjes/fjes_ethtool.c
>  create mode 100644 drivers/net/fjes/fjes_hw.c
>  create mode 100644 drivers/net/fjes/fjes_hw.h
>  create mode 100644 drivers/net/fjes/fjes_main.c
>  create mode 100644 drivers/net/fjes/fjes_regs.h
> 



-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Sr. Network Kernel Developer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer

  parent reply	other threads:[~2015-06-24 13:41 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-24  2:52 [PATCH v2 00/22] FUJITSU Extended Socket network device driver Taku Izumi
2015-06-24  2:55 ` [PATCH v2 01/22] fjes: Introduce FUJITSU Extended Socket Network Device driver Taku Izumi
2015-06-24  6:50   ` Joe Perches
2015-06-25  0:32     ` Izumi, Taku
2015-06-24  2:55 ` [PATCH v2 02/22] fjes: Hardware initialization routine Taku Izumi
2015-07-07 16:38   ` Yasuaki Ishimatsu
2015-06-24  2:55 ` [PATCH v2 03/22] fjes: Hardware cleanup routine Taku Izumi
2015-06-24  2:55 ` [PATCH v2 04/22] fjes: platform_driver's .probe and .remove routine Taku Izumi
2015-06-24  2:55 ` [PATCH v2 05/22] fjes: ES information acquisition routine Taku Izumi
2015-06-24  2:55 ` [PATCH v2 06/22] fjes: buffer address regist/unregistration routine Taku Izumi
2015-07-06 19:35   ` Yasuaki Ishimatsu
2015-07-07 18:35   ` Yasuaki Ishimatsu
2015-06-24  2:55 ` [PATCH v2 07/22] fjes: net_device_ops.ndo_open and .ndo_stop Taku Izumi
2015-06-24  2:55 ` [PATCH v2 08/22] fjes: net_device_ops.ndo_start_xmit Taku Izumi
2015-07-10 19:21   ` Yasuaki Ishimatsu
2015-06-24  2:55 ` [PATCH v2 09/22] fjes: raise_intr_rxdata_task Taku Izumi
2015-06-24  2:55 ` [PATCH v2 10/22] fjes: tx_stall_task Taku Izumi
2015-07-13 16:03   ` Yasuaki Ishimatsu
2015-06-24  2:55 ` [PATCH v2 11/22] fjes: NAPI polling function Taku Izumi
2015-06-24  2:55 ` [PATCH v2 12/22] fjes: net_device_ops.ndo_get_stats64 Taku Izumi
2015-06-24  2:55 ` [PATCH v2 13/22] fjes: net_device_ops.ndo_change_mtu Taku Izumi
2015-06-24  2:55 ` [PATCH v2 14/22] fjes: net_device_ops.ndo_tx_timeout Taku Izumi
2015-06-24  2:55 ` [PATCH v2 15/22] fjes: net_device_ops.ndo_vlan_rx_add/kill_vid Taku Izumi
2015-07-13 16:54   ` Yasuaki Ishimatsu
2015-06-24  2:55 ` [PATCH v2 16/22] fjes: interrupt_watch_task Taku Izumi
2015-06-24  2:55 ` [PATCH v2 17/22] fjes: force_close_task Taku Izumi
2015-06-24  2:55 ` [PATCH v2 18/22] fjes: unshare_watch_task Taku Izumi
2015-07-13 18:35   ` Yasuaki Ishimatsu
2015-06-24  2:55 ` [PATCH v2 19/22] fjes: update_zone_task Taku Izumi
2015-06-24  2:55 ` [PATCH v2 20/22] fjes: epstop_task Taku Izumi
2015-06-24  2:55 ` [PATCH v2 21/22] fjes: handle receive cancellation request interrupt Taku Izumi
2015-06-24  2:55 ` [PATCH v2 22/22] fjes: ethtool support Taku Izumi
2015-06-24 13:41 ` Jesper Dangaard Brouer [this message]
2015-06-25  0:32   ` [PATCH v2 00/22] FUJITSU Extended Socket network device driver Izumi, Taku

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150624154113.4b41db79@redhat.com \
    --to=brouer@redhat.com \
    --cc=alexander.h.duyck@redhat.com \
    --cc=dvhart@infradead.org \
    --cc=izumi.taku@jp.fujitsu.com \
    --cc=joe@perches.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rkhan@redhat.com \
    --cc=yasu.isimatu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.