All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peng Fan <b51431@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] imx: mx6 remove duplicated enable_cspi_clock
Date: Thu, 25 Jun 2015 09:10:19 +0800	[thread overview]
Message-ID: <20150625011015.GA28827@shlinux2> (raw)
In-Reply-To: <CAOMZO5B-kte0sdgx_KR0BPT5gWt95JJ7jufv2UaUXYwOiMpYsA@mail.gmail.com>

On Wed, Jun 24, 2015 at 12:53:40PM -0300, Fabio Estevam wrote:
>On Wed, Jun 24, 2015 at 7:44 AM, Peng Fan <Peng.Fan@freescale.com> wrote:
>> enable_spi_clock does the same thing with enable_cspi_clock.
>>
>> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
>> ---
>>  arch/arm/cpu/armv7/mx6/clock.c | 19 -------------------
>>  1 file changed, 19 deletions(-)
>>
>> diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c
>> index ae99945..1134770 100644
>> --- a/arch/arm/cpu/armv7/mx6/clock.c
>> +++ b/arch/arm/cpu/armv7/mx6/clock.c
>> @@ -102,25 +102,6 @@ void enable_uart_clk(unsigned char enable)
>>  }
>>  #endif
>>
>> -#ifdef CONFIG_SPI
>> -/* spi_num can be from 0 - 4 */
>> -int enable_cspi_clock(unsigned char enable, unsigned spi_num)
>> -{
>> -       u32 mask;
>> -
>> -       if (spi_num > 4)
>> -               return -EINVAL;
>> -
>> -       mask = MXC_CCM_CCGR_CG_MASK << (spi_num * 2);
>> -       if (enable)
>> -               setbits_le32(&imx_ccm->CCGR1, mask);
>> -       else
>> -               clrbits_le32(&imx_ccm->CCGR1, mask);
>> -
>> -       return 0;
>> -}
>> -#endif
>> -
>
>This patch causes board/compulab/cm_fx6/spl.c to fail to build.
>
>I see that you fix board/compulab/cm_fx6/spl.c in a later patch in
>your series, but it should be part of the same patch to avoid the
>build breakage.
>
I thought board and arch code should not be in one patch,
so I splitted it into two patch. Will fix it in v2.
>You should also remove the function prototype from
>arch/arm/include/asm/arch-mx6/clock.h.
Thanks for pointing this out. Will fix in v2.
>
>Regards,
>
>Fabio Estevam

Thanks,
Peng
-- 

      reply	other threads:[~2015-06-25  1:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-24 10:44 [U-Boot] [PATCH 1/3] imx: mx6 remove duplicated enable_cspi_clock Peng Fan
2015-06-24 10:44 ` [U-Boot] [PATCH 2/3] imx: cm_fx6 use enable_spi_clk Peng Fan
2015-06-24 10:44 ` [U-Boot] [PATCH 3/3] imx: mx6 add i2c4 clock support for i.MX6SX Peng Fan
2015-06-24 15:53 ` [U-Boot] [PATCH 1/3] imx: mx6 remove duplicated enable_cspi_clock Fabio Estevam
2015-06-25  1:10   ` Peng Fan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150625011015.GA28827@shlinux2 \
    --to=b51431@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.