From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [GIT PULL] f2fs updates for v4.2 Date: Thu, 25 Jun 2015 07:32:36 +0100 Message-ID: <20150625063235.GV17109@ZenIV.linux.org.uk> References: <20150624202401.GA40031@jaegeuk-mac02.mot.com> <20150625043334.GT17109@ZenIV.linux.org.uk> <20150625054917.GA43469@jaegeuk-mac02.hsd1.ca.comcast.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1Z80iN-00009F-5D for linux-f2fs-devel@lists.sourceforge.net; Thu, 25 Jun 2015 06:32:47 +0000 Received: from zeniv.linux.org.uk ([195.92.253.2]) by sog-mx-2.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1Z80iK-00081y-1R for linux-f2fs-devel@lists.sourceforge.net; Thu, 25 Jun 2015 06:32:47 +0000 Content-Disposition: inline In-Reply-To: <20150625054917.GA43469@jaegeuk-mac02.hsd1.ca.comcast.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Jaegeuk Kim Cc: Linux FS Dev Mailing List , Stephen Rothwell , Linus Torvalds , Linux Kernel Mailing List , Linux F2FS Dev Mailing List On Wed, Jun 24, 2015 at 10:50:10PM -0700, Jaegeuk Kim wrote: > Right, I missed merging the fix-up patch in linux-next into my pull-request. > At a glance, I think there is no problem; except 80 column width, though. > > Also, agreed that I need to take a look at deleting the dentry to deal with that > failure case. Why not set the symlink up first and create a directory entry only if that succeeds? Looks like it's less work that way... ------------------------------------------------------------------------------ Monitor 25 network devices or servers for free with OpManager! OpManager is web-based network management software that monitors network devices and physical & virtual servers, alerts via email & sms for fault. Monitor 25 devices for free with no restriction. Download now http://ad.doubleclick.net/ddm/clk/292181274;119417398;o From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751701AbbFYGco (ORCPT ); Thu, 25 Jun 2015 02:32:44 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:58603 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751534AbbFYGci (ORCPT ); Thu, 25 Jun 2015 02:32:38 -0400 Date: Thu, 25 Jun 2015 07:32:36 +0100 From: Al Viro To: Jaegeuk Kim Cc: Linus Torvalds , Linux Kernel Mailing List , Linux FS Dev Mailing List , Linux F2FS Dev Mailing List , Stephen Rothwell Subject: Re: [GIT PULL] f2fs updates for v4.2 Message-ID: <20150625063235.GV17109@ZenIV.linux.org.uk> References: <20150624202401.GA40031@jaegeuk-mac02.mot.com> <20150625043334.GT17109@ZenIV.linux.org.uk> <20150625054917.GA43469@jaegeuk-mac02.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150625054917.GA43469@jaegeuk-mac02.hsd1.ca.comcast.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 24, 2015 at 10:50:10PM -0700, Jaegeuk Kim wrote: > Right, I missed merging the fix-up patch in linux-next into my pull-request. > At a glance, I think there is no problem; except 80 column width, though. > > Also, agreed that I need to take a look at deleting the dentry to deal with that > failure case. Why not set the symlink up first and create a directory entry only if that succeeds? Looks like it's less work that way...