From: Johan Hovold <johan@kernel.org>
To: Peter Hung <hpeter@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, peter_hong@fintek.com.tw,
tom_tsai@fintek.com.tw,
Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V2 1/1] usb:serial:f81534 Add F81532/534 Driver
Date: Thu, 25 Jun 2015 11:25:47 +0200 [thread overview]
Message-ID: <20150625092547.GB28464@localhost> (raw)
In-Reply-To: <558BC7FD.100@gmail.com>
On Thu, Jun 25, 2015 at 05:21:01PM +0800, Peter Hung wrote:
> Hi Johan,
>
> Johan Hovold 於 2015/6/25 下午 04:06 寫道:
> > - As Greg already mentioned, you need to implement gpio support using
> > gpiolib, not a custom sysfs interface
> >
> > I don't have time to look closer at the architectural bits until next
> > week I'm afraid, but perhaps you could start with the above.
>
> Thanks for your advices, I'll try to improve it again.
> But I had something need to clarify.
>
> 1. The sysfs interface of the driver provide "limited output pin"
> control. only support output 0/1, not support input mode.
> Should I implement it as gpiolib?
Yes.
> 2. If it still recommends to implement with gpiolib, Could I implement
> it and preserve the sysfs interface for legacy?
No, I'm afraid not. We don't want to have to maintain out-of-tree legacy
interfaces.
Johan
next prev parent reply other threads:[~2015-06-25 9:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 1:54 [PATCH V2 1/1] usb:serial:f81534 Add F81532/534 Driver Peter Hung
2015-06-25 5:16 ` Peter Hung
2015-06-25 8:06 ` Johan Hovold
2015-06-25 9:21 ` Peter Hung
2015-06-25 9:25 ` Johan Hovold [this message]
2015-07-06 11:33 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150625092547.GB28464@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=hpeter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter_hong@fintek.com.tw \
--cc=tom_tsai@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.