From: Karel Zak <kzak@redhat.com>
To: kerolasa@gmail.com
Cc: Andreas Henriksson <andreas@fatal.se>,
util-linux <util-linux@vger.kernel.org>,
Andreas Henriksson <andreas.henriksson@endian.se>
Subject: Re: [PATCH] rename: allow full-path renames
Date: Thu, 25 Jun 2015 12:06:18 +0200 [thread overview]
Message-ID: <20150625100618.GQ1992@ws.net.home> (raw)
In-Reply-To: <CAG27Bk353ASGr0hyDe4oQvAZ3Swf_HbgonENtkOPFE_qcjE7MQ@mail.gmail.com>
On Mon, Jun 22, 2015 at 06:08:53PM +0100, Sami Kerola wrote:
> Change looks good, but I would add a test to avoid same regression
> happening in future. The same change with test can be found from
> my git.
>
> https://github.com/kerolasa/lelux-utiliteetit/commit/19ef4954935c65559e7561b4b3becbe462848127
I have applied Andreas' test (but if you want to submit more tests
then go ahead :-)
Please, keep tests in the independent commits.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2015-06-25 10:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 16:23 [PATCH] rename: allow full-path renames Andreas Henriksson
2015-06-22 17:08 ` Sami Kerola
2015-06-22 17:22 ` [PATCH] tests: add fullpath tests to rename/subdir Andreas Henriksson
2015-06-25 10:03 ` Karel Zak
2015-06-22 17:26 ` [PATCH v2] rename: allow full-path renames Andreas Henriksson
2015-06-25 10:04 ` Karel Zak
2015-06-22 17:29 ` [PATCH] " Andreas Henriksson
2015-06-25 10:06 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150625100618.GQ1992@ws.net.home \
--to=kzak@redhat.com \
--cc=andreas.henriksson@endian.se \
--cc=andreas@fatal.se \
--cc=kerolasa@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.