From: Jens Axboe <axboe@kernel.dk>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: fio@vger.kernel.org
Subject: Re: [PATCH] Fix testing and setting set_options bitmap
Date: Thu, 25 Jun 2015 09:22:33 -0600 [thread overview]
Message-ID: <20150625152233.GE13739@kernel.dk> (raw)
In-Reply-To: <1435239581-6642-1-git-send-email-akinobu.mita@gmail.com>
On Thu, Jun 25 2015, Akinobu Mita wrote:
> set_options bitmap is an array of uint64_t. But while testing and
> setting a bit in the bitmap, the bit mask is calculated with an
> unsigned long value. For the systems which have 32-bit long type,
> upper 32-bit cannot be set correctly.
>
> Fix it by using (uint64_t)1 instead of 1UL to calculate correct bit
> mask.
Thanks, applied.
--
Jens Axboe
prev parent reply other threads:[~2015-06-25 15:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 13:39 [PATCH] Fix testing and setting set_options bitmap Akinobu Mita
2015-06-25 15:22 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150625152233.GE13739@kernel.dk \
--to=axboe@kernel.dk \
--cc=akinobu.mita@gmail.com \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.