From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
orgerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
raid-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH RFC 2/2] RDMA/isert: Support iWARP transport
Date: Thu, 25 Jun 2015 12:25:05 -0600 [thread overview]
Message-ID: <20150625182505.GA15337@obsidianresearch.com> (raw)
In-Reply-To: <20150625153922.13272.41789.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>
On Thu, Jun 25, 2015 at 10:39:23AM -0500, Steve Wise wrote:
> + /*
> + * IWARP transports need REMOTE_WRITE for MRs used as the target of
> + * an RDMA_READ. Since the DMA MR is used for all ports, then if
> + * any port is running IWARP, add REMOTE_WRITE.
> + */
> + if (any_port_is_iwarp(device))
It would be nice to have a new-style cap test for this instead of open
coding iwarp. Similar to rdma_cap_read_multi_sge
I'm confused about the 'any_port_is_iwarp' stuff too, I thought if one
port was iwarp then all ports had to be iwarp?
Even if we move away from that, I would think that some caps must be
the same on all ports, and multi_sge, remote_write, etc would fit into
that limitation.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-06-25 18:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 15:39 [PATCH RFC 0/2] iSER support for iWARP Steve Wise
[not found] ` <20150625153754.13272.432.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>
2015-06-25 15:39 ` [PATCH RFC 1/2] RDMA/iser: limit sg tablesize on device fastreg max depth Steve Wise
[not found] ` <20150625153917.13272.52513.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>
2015-06-25 16:36 ` Sagi Grimberg
2015-06-25 15:39 ` [PATCH RFC 2/2] RDMA/isert: Support iWARP transport Steve Wise
[not found] ` <20150625153922.13272.41789.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>
2015-06-25 16:51 ` Sagi Grimberg
2015-06-25 17:06 ` Steve Wise
2015-06-27 9:12 ` Sagi Grimberg
[not found] ` <558E68EB.9040205-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-06-29 17:46 ` Jason Gunthorpe
[not found] ` <558C317E.4010402-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-06-27 9:10 ` Sagi Grimberg
2015-06-25 18:25 ` Jason Gunthorpe [this message]
[not found] ` <20150625182505.GA15337-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-06-25 18:30 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373A8FF9D60-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-06-25 18:33 ` Steve Wise
2015-06-25 18:45 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373A8FF9D96-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-06-25 19:12 ` Jason Gunthorpe
[not found] ` <20150625191220.GA15726-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-06-25 19:20 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373A8FF9DF9-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-06-25 19:25 ` Steve Wise
2015-06-25 19:29 ` Jason Gunthorpe
[not found] ` <20150625192934.GB15726-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-06-25 19:44 ` Steve Wise
2015-06-27 9:33 ` Sagi Grimberg
2015-06-25 19:59 ` Steve Wise
2015-06-25 18:32 ` Steve Wise
2015-06-25 16:58 ` [PATCH RFC 0/2] iSER support for iWARP Sagi Grimberg
2015-06-25 17:01 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150625182505.GA15337@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=orgerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=raid-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.