All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: steve.norman@thomsonreuters.com
Cc: pclouds@gmail.com, junio@pobox.com, git@vger.kernel.org
Subject: Re: [ANNOUNCE] Git v2.5.0-rc0
Date: Fri, 26 Jun 2015 07:20:41 -0400	[thread overview]
Message-ID: <20150626112040.GA4315@peff.net> (raw)
In-Reply-To: <7FAE15F0A93C0144AD8B5FBD584E1C55197CF80F@C111KJZHMBX55.ERF.thomson.com>

On Fri, Jun 26, 2015 at 09:36:04AM +0000, steve.norman@thomsonreuters.com wrote:

> Jeff / Duy,
> 
> > Fixes since v2.4
> >  * Access to objects in repositories that borrow from another one on a
> >    slow NFS server unnecessarily got more expensive due to recent code
> >    becoming more cautious in a naive way not to lose objects to pruning.
> >    (merge ee1c6c3 jk/prune-mtime later to maint).
> > 
> >  * "Have we lost a race with competing repack?" check was too
> >    expensive, especially while receiving a huge object transfer
> >    that runs index-pack (e.g. "clone" or "fetch").
> >    (merge 0eeb077 jk/index-pack-reduce-recheck later to maint).
> 
> I was reading through the 2.5 release notes and spotted the above two
> entries and I think they are probably fixes related to the NFS
> slowness I reported last month.

Yep, especially the latter one.

> Did some tests this morning and things are much improved:
> 
> Version 2.4.5
>   - Local clone of https://github.com/git/git - 8s
>   - Clone to NFS - 1m 3s
> 
> Version 2.5.0.rc0
>   - Local - 7s
>   - NFS - 13s
> 
> Thanks for the effort in addressing this and sorry I missed the patch to check it out earlier.

No problem, and thanks for the original report. It gave me plenty to
replicate the problem locally, so I felt pretty good about the changes
even without a final test from you. :)

-Peff

      reply	other threads:[~2015-06-26 11:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25 20:19 [ANNOUNCE] Git v2.5.0-rc0 Junio C Hamano
2015-06-26  9:36 ` steve.norman
2015-06-26 11:20   ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150626112040.GA4315@peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=junio@pobox.com \
    --cc=pclouds@gmail.com \
    --cc=steve.norman@thomsonreuters.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.