From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Xenomai <xenomai@xenomai.org>
Subject: Re: [Xenomai] Heads up: some race condition fixes for Xenomai 3
Date: Fri, 26 Jun 2015 17:07:51 +0200 [thread overview]
Message-ID: <20150626150751.GA6095@hermes.click-hack.org> (raw)
In-Reply-To: <558D5FAD.3060003@siemens.com>
On Fri, Jun 26, 2015 at 04:20:29PM +0200, Jan Kiszka wrote:
> Hi,
>
> just pushed 3 patches to git.xenomai.org/xenomai-jki.git for-forge that
> are supposed to fix race conditions while manipulating xnthread::state
> and info (both need to be nklock-protected). Please review if finding
> and fixes make sense.
>
> cobalt/kernel: Fix locking for xnthread info manipulations
> cobalt/kernel: Fix locking for setting XNFPU
> cobalt/kernel: Rework thread debugging helpers
>
> Maybe some of the issues also exist in Xenomai 2, didn't check yet.
At some point, one of info and state was supposed to be only
modified by the current thread, but I am not sure this still holds.
Anyway, instead of adding explicit nklock sections around
xnthread_clear_info/xnthread_set_info, would not it be better to
have xnthread_clear_info/xnthread_set_info implicitly take the lock,
and add __xnthread_clear_info/__xnthread_set_info for the sections
where the caller already holds the nklock?
--
Gilles.
https://click-hack.org
next prev parent reply other threads:[~2015-06-26 15:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 14:20 [Xenomai] Heads up: some race condition fixes for Xenomai 3 Jan Kiszka
2015-06-26 15:07 ` Gilles Chanteperdrix [this message]
2015-06-26 15:24 ` Jan Kiszka
2017-03-07 18:34 ` Henning Schild
2017-03-08 8:54 ` Philippe Gerum
2017-03-08 11:25 ` Jan Kiszka
2017-03-08 11:29 ` Philippe Gerum
2017-03-08 11:32 ` Jan Kiszka
2017-03-08 11:42 ` Philippe Gerum
2017-03-08 11:48 ` Philippe Gerum
2017-03-09 9:05 ` Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150626150751.GA6095@hermes.click-hack.org \
--to=gilles.chanteperdrix@xenomai.org \
--cc=jan.kiszka@siemens.com \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.