From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 2/2] arm/smmu: Make use of of_parse_phandle_with_var_args Date: Fri, 26 Jun 2015 17:44:03 +0200 Message-ID: <20150626154403.GD18569@8bytes.org> References: <1435247548-32201-1-git-send-email-joro@8bytes.org> <1435247548-32201-2-git-send-email-joro@8bytes.org> <20150626111047.GA9791@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20150626111047.GA9791-5wv7dgnIgG8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Will Deacon Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Joerg Roedel , Andre Przywara , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , Rob Herring , "grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: iommu@lists.linux-foundation.org Hi Will, On Fri, Jun 26, 2015 at 12:10:47PM +0100, Will Deacon wrote: > Thanks for looking at this! I'm fine with the general idea, but obviously > the first patch needs an Ack from a devicetree person. Yeah, sure. I was looking into a simple solution that does not require to rewrite all the callers. Lets see what the device-tree maintainers think about it :) > > out_put_masters: > > + > > + of_free_phandle_args(masterspec); > > Shouldn't we also free the masterspec on success? Right, thanks. This code is only the error path. I'll add this in the next version. Joerg From mboxrd@z Thu Jan 1 00:00:00 1970 From: joro@8bytes.org (Joerg Roedel) Date: Fri, 26 Jun 2015 17:44:03 +0200 Subject: [PATCH 2/2] arm/smmu: Make use of of_parse_phandle_with_var_args In-Reply-To: <20150626111047.GA9791@arm.com> References: <1435247548-32201-1-git-send-email-joro@8bytes.org> <1435247548-32201-2-git-send-email-joro@8bytes.org> <20150626111047.GA9791@arm.com> Message-ID: <20150626154403.GD18569@8bytes.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Will, On Fri, Jun 26, 2015 at 12:10:47PM +0100, Will Deacon wrote: > Thanks for looking at this! I'm fine with the general idea, but obviously > the first patch needs an Ack from a devicetree person. Yeah, sure. I was looking into a simple solution that does not require to rewrite all the callers. Lets see what the device-tree maintainers think about it :) > > out_put_masters: > > + > > + of_free_phandle_args(masterspec); > > Shouldn't we also free the masterspec on success? Right, thanks. This code is only the error path. I'll add this in the next version. Joerg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752437AbbFZPoK (ORCPT ); Fri, 26 Jun 2015 11:44:10 -0400 Received: from 8bytes.org ([81.169.241.247]:55406 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751897AbbFZPoF (ORCPT ); Fri, 26 Jun 2015 11:44:05 -0400 Date: Fri, 26 Jun 2015 17:44:03 +0200 From: Joerg Roedel To: Will Deacon Cc: Rob Herring , "grant.likely@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Andre Przywara , Joerg Roedel Subject: Re: [PATCH 2/2] arm/smmu: Make use of of_parse_phandle_with_var_args Message-ID: <20150626154403.GD18569@8bytes.org> References: <1435247548-32201-1-git-send-email-joro@8bytes.org> <1435247548-32201-2-git-send-email-joro@8bytes.org> <20150626111047.GA9791@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150626111047.GA9791@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Will, On Fri, Jun 26, 2015 at 12:10:47PM +0100, Will Deacon wrote: > Thanks for looking at this! I'm fine with the general idea, but obviously > the first patch needs an Ack from a devicetree person. Yeah, sure. I was looking into a simple solution that does not require to rewrite all the callers. Lets see what the device-tree maintainers think about it :) > > out_put_masters: > > + > > + of_free_phandle_args(masterspec); > > Shouldn't we also free the masterspec on success? Right, thanks. This code is only the error path. I'll add this in the next version. Joerg