All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andreas Hartmann <andihartmann@01019freenet.de>
Cc: Richard Weinberger <richard.weinberger@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: f_op->read seems to be always NULL since Linux 4.1
Date: Sun, 28 Jun 2015 09:30:08 +0100	[thread overview]
Message-ID: <20150628083008.GW17109@ZenIV.linux.org.uk> (raw)
In-Reply-To: <558F95E2.7070303@01019freenet.de>

On Sun, Jun 28, 2015 at 08:36:18AM +0200, Andreas Hartmann wrote:
> On Sat, Jun 27, 2015 at 8:10 PM, Richard Weinberger wrote:
> >On Sat, Jun 27, 2015 at 7:32 PM, Andreas Hartmann
> ><andihartmann@01019freenet.de> wrote:
> [...]
> >See __vfs_read().
> >Your module most not rely on such internals.
> 
> Thanks for your hint to the function which exists since 3.19.
> 
> Is there a site out there which lists all relevant changes done for
> each kernel version and the recommendations how to correctly handle
> them?

localhost.  It's in Documentation/filesystems/porting in the kernel
source.  To quote the relevant entry (not far from the end - they
are in chronological order):

[mandatory]
        never call ->read() and ->write() directly; use __vfs_{read,write} or
        wrappers; instead of checking for ->write or ->read being NULL, look for
        FMODE_CAN_{WRITE,READ} in file->f_mode.

Sometimes TFM to R _is_ in the natural place...

      parent reply	other threads:[~2015-06-28  8:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-27 17:32 f_op->read seems to be always NULL since Linux 4.1 Andreas Hartmann
2015-06-27 18:10 ` Richard Weinberger
2015-06-28  6:36   ` Andreas Hartmann
2015-06-28  7:38     ` Richard Weinberger
2015-06-28  8:30     ` Al Viro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150628083008.GW17109@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=andihartmann@01019freenet.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard.weinberger@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.