From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: compatability with older versions of UEFI Date: Sun, 28 Jun 2015 15:34:13 +0100 Message-ID: <20150628143413.GB28334@codeblueprint.co.uk> References: <20150623170534.GA21341@agluck-desk.sc.intel.com> <558AF115.8020909@codeaurora.org> <3908561D78D1C84285E8C5FCA982C28F32A9FB7C@ORSMSX114.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F32A9FB7C-8oqHQFITsIE64kNsxIetb7fspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Luck, Tony" Cc: "Zhang, Jonathan Zhixiong" , "Fleming, Matt" , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "harba-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , "linaro-acpi-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" List-Id: linux-efi@vger.kernel.org On Wed, 24 Jun, at 07:14:43PM, Luck, Tony wrote: > > Another option would be to have 2 structs, the first one > > "struct cper_sec_mem_err" holds the structure as defined by UEFI > > 2.1, the 2nd one "struct cper_sec_mem_err_24_ext" holds the 4 > > elements added in UEFI 2.3.1. > > Reading some more of the UEFI 2.5 spec ... I see we are in for a world of pain > here. > > 2.5 adds some small tweaks to the memory structure (adding a couple of extra > bits to the "row" entry that can be grabbed from the formerly reserved byte > at offset 73). But then there is a whole new GUID for a "Memory Error Section 2" > which has doubled the width of the device, row, column, rank, and bit_pos fields > together with adding two new fields for chip_id and status. This will be painful > because we hardwired the old sizes into extlog_mem_event in Can't you just create a new memory event type? Granted, you'll need changes to the ras daemon, but since there's a new GUID involved I think that's forgivable. -- Matt Fleming, Intel Open Source Technology Center