All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: "Jörg Otte" <jrg.otte@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	"bluez mailin list (linux-bluetooth@vger.kernel.org)"
	<linux-bluetooth@vger.kernel.org>,
	inux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [4.1.0-07254-gc13c810] Regression: Bluetooth not working.
Date: Sun, 28 Jun 2015 19:09:31 +0300	[thread overview]
Message-ID: <20150628160930.GA1663@p183.telecom.by> (raw)
In-Reply-To: <CADDKRnCx4AM9jnf5HfbkB0iNQqxsyLCTozCrasF2c8e7V2K_gw@mail.gmail.com>

On Sun, Jun 28, 2015 at 05:36:04PM +0200, Jörg Otte wrote:
> 2015-06-26 16:28 GMT+02:00 Jörg Otte <jrg.otte@gmail.com>:
> > 2015-06-26 12:03 GMT+02:00 Jörg Otte <jrg.otte@gmail.com>:
> >> 2015-06-26 11:37 GMT+02:00 Marcel Holtmann <marcel@holtmann.org>:
> >>> Hi Joerg,
> >>>
> >>>> Bluetooth is inoperable in current Linus tree and the
> >>>> first bad commit is:
> >>>>
> >>>> 835a6a2f8603237a3e6cded5a6765090ecb06ea5 is the first bad commit
> >>>> commit 835a6a2f8603237a3e6cded5a6765090ecb06ea5
> >>>> Author: Alexey Dobriyan <adobriyan@gmail.com>
> >>>> Date:   Wed Jun 10 20:28:33 2015 +0300
> >>>>
> >>>>    Bluetooth: Stop sabotaging list poisoning
> >>>>
> >>>>    list_del() poisons pointers with special values, no need to overwrite them.
> >>>>
> >>>>    Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> >>>>    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> >>>>
> >>>> My BT adapter is an intel 8087:07da
> >>>> I reverted that commit and this fixed the problem for me.
> >>>
> >>> today we had a patch from Tedd fixing the list initialization in the HIDP code.
> >>>
> >>> diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
> >>> index 9070dfd6b4ad..f1a117f8cad2 100644
> >>> --- a/net/bluetooth/hidp/core.c
> >>> +++ b/net/bluetooth/hidp/core.c
> >>> @@ -915,6 +915,7 @@ static int hidp_session_new(struct hidp_session **out, const bdaddr_t *bdaddr,
> >>>         session->conn = l2cap_conn_get(conn);
> >>>         session->user.probe = hidp_session_probe;
> >>>         session->user.remove = hidp_session_remove;
> >>> +       INIT_LIST_HEAD(&session->user.list);
> >>>         session->ctrl_sock = ctrl_sock;
> >>>         session->intr_sock = intr_sock;
> >>>         skb_queue_head_init(&session->ctrl_transmit);
> >>>
> >>> Could this be fixing it for you as well?
> >>>
> >> I will check this when I am at home in the
> >> afternoon.
> >>
> >
> > The patch works for me too.
> >
> Ok, this was a little bit hasty!
> I now see the following additional problems:
> 
> - System freeze on resume (occures always).
> - System freeze on shutdown (occures sometimes)
> - System freeze when BT-mouse is connecting (occures sometimes).
> 
> Then I can't do anything except power off.
> 
> This happens only if Bluetooth AND BT-mouse is activated.

OK, what happens if you just revert only list_del patch?

  reply	other threads:[~2015-06-28 16:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-26  9:27 [4.1.0-07254-gc13c810] Regression: Bluetooth not working Jörg Otte
2015-06-26  9:27 ` Jörg Otte
2015-06-26  9:37 ` Marcel Holtmann
2015-06-26 10:03   ` Jörg Otte
2015-06-26 10:03     ` Jörg Otte
2015-06-26 10:27     ` Alexey Dobriyan
2015-06-26 10:27       ` Alexey Dobriyan
2015-06-26 14:28     ` Jörg Otte
2015-06-26 14:28       ` Jörg Otte
2015-06-28 15:36       ` Jörg Otte
2015-06-28 15:36         ` Jörg Otte
2015-06-28 16:09         ` Alexey Dobriyan [this message]
2015-06-29  9:00           ` Jörg Otte
2015-06-29  9:00             ` Jörg Otte
2015-06-29 10:30             ` Alexey Dobriyan
2015-06-29 10:30               ` Alexey Dobriyan
2015-06-29 14:37               ` Jörg Otte
2015-06-29 14:37                 ` Jörg Otte
2015-06-29 21:13                 ` Tedd Ho-Jeong An
2015-06-29 21:13                   ` Tedd Ho-Jeong An
2015-06-30 14:58                   ` Jörg Otte
2015-06-30 14:58                     ` Jörg Otte
2015-06-30 18:47                     ` Tedd Ho-Jeong An
2015-06-30 18:47                       ` Tedd Ho-Jeong An

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150628160930.GA1663@p183.telecom.by \
    --to=adobriyan@gmail.com \
    --cc=johan.hedberg@gmail.com \
    --cc=jrg.otte@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.