From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v3] drm/tegra: Use 64-bit offset for tegra_gem_mmap Date: Mon, 29 Jun 2015 10:50:00 +0200 Message-ID: <20150629084959.GB5431@ulmo> References: <20150130094935.GB16744@ulmo> <1422644221-24432-1-git-send-email-seanpaul@chromium.org> <20150206121826.GA18585@ulmo.nvidia.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1526986265==" Return-path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by gabe.freedesktop.org (Postfix) with ESMTPS id 405D16E818 for ; Mon, 29 Jun 2015 01:51:10 -0700 (PDT) Received: by wiwl6 with SMTP id l6so92635019wiw.0 for ; Mon, 29 Jun 2015 01:51:09 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dave Airlie Cc: =?utf-8?B?U3TDqXBoYW5l?= Marchesin , dri-devel List-Id: dri-devel@lists.freedesktop.org --===============1526986265== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ftEhullJWpWg/VHq" Content-Disposition: inline --ftEhullJWpWg/VHq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 29, 2015 at 02:16:17PM +1000, Dave Airlie wrote: > On 6 February 2015 at 22:18, Thierry Reding wr= ote: > > On Fri, Jan 30, 2015 at 01:57:01PM -0500, Sean Paul wrote: > >> On 64-bit targets, tegra_gem_mmap doesn't return the > >> offset to userspace. As such, subsequent calls to mmap(2) > >> fail. Alter the args to use 64-bit offset to fix this. > >> > >> Signed-off-by: Sean Paul > >> --- > >> include/uapi/drm/tegra_drm.h | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > > > > I've applied this with a slightly tweaked commit message. >=20 > Doesn't that break 32-bit ABI? Yes it does. This was discussed earlier in this thread. The original patch was to add a separate IOCTL to be used on 64-bit architectures because the 32-bit IOCTL was broken. After some discussion everybody involved agreed that it'd be best to fix the IOCTL while we can (the driver-specific IOCTLs in the Tegra driver are all guarded by the STAGING Kconfig symbol). Thierry --ftEhullJWpWg/VHq Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVkQa3AAoJEN0jrNd/PrOhvy8QAI3+N4t2s9yzjOowpC+nWoIa h923gt156+oeLIuFuBON3TlE8nTftcQXn0trcU2qW329Q8/RJStBcvmAqQ78AGDO ZuPLmTeH2+prEmtFBJFhq0gKtwM8HWxoe+Qu+XgZSmWcsTDDKWhJ6xScECiZp9f0 xn/8yMcldDiYnX+QG6gXqpZQtOCGzDWvGs+98Sd7DbNS6tLR3dpERjHjeH0gnYNy y4KtgdPc2st8YFKT6u2UDiPcUoBTuO800AV2xUZMcfEfUzt6+5jpVgFsm0OgNZIs EpmibY3VseaZgl1VE8Lq5MOqXYeiFKsx9KN1YXFig9g8brau4jz7LKMmwI+PolFl MVTGXUjonuiMvcoX3ePgjN02BQ48hpVLH3xdaBad3NoMswBJGBnBtTZvRj5XZ5HF ZRtDLzX96XDGSyO9G4nwSRxcbVnJAQrOEvwx6o2wM7+UvbMWZ+dD0aOQ67UQeNnS LtXCB7cAb4/lASEkuBC7rV3pu0V3Tf3pC1rk+6qpT/BgjxWQS5v3pa2eMD2v96xC vnb5P/+NwAS4qtnZyv5Um6iT5RkoDpWuwl2em/J82BoUpcjJCYGaKM7CX6BcDbdz mY2NQAFXX9Mc6nkogRsv2+3STSPQXezgOoaIPsL3CME8l138OckCsCK0OGfh7io1 iUZaQazqdDk+G2I1ZdJQ =pL7L -----END PGP SIGNATURE----- --ftEhullJWpWg/VHq-- --===============1526986265== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1526986265==--