All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: "penberg@kernel.org" <penberg@kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] kvmtool: don't use PCI config space IRQ line field
Date: Mon, 29 Jun 2015 11:10:05 +0100	[thread overview]
Message-ID: <20150629101004.GB17474@arm.com> (raw)
In-Reply-To: <5582FDB9.3020700@arm.com>

Hi Andre,

On Thu, Jun 18, 2015 at 06:19:53PM +0100, Andre Przywara wrote:
> I am tempted to remove shmem, since it's broken:
> a) there is no upstream driver, only some out-of-tree uio driver module
> in some Github repo

Right, but that's the same for qemu and we've already made the jump of
merging the driver, so I don't think that's a good argument for throwing
it out of the tree.

> b) the PCI device BARs do not match what QEMU implements and what the
> uio driver expects (IO BAR vs. MMIO BAR)

In what way? A quick look suggests that kvmtool is at least aligned with
said github repo.

> c) there is (at least one) bug in kvmtool (easily fixed, though)

Care to elaborate?

Will

WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] kvmtool: don't use PCI config space IRQ line field
Date: Mon, 29 Jun 2015 11:10:05 +0100	[thread overview]
Message-ID: <20150629101004.GB17474@arm.com> (raw)
In-Reply-To: <5582FDB9.3020700@arm.com>

Hi Andre,

On Thu, Jun 18, 2015 at 06:19:53PM +0100, Andre Przywara wrote:
> I am tempted to remove shmem, since it's broken:
> a) there is no upstream driver, only some out-of-tree uio driver module
> in some Github repo

Right, but that's the same for qemu and we've already made the jump of
merging the driver, so I don't think that's a good argument for throwing
it out of the tree.

> b) the PCI device BARs do not match what QEMU implements and what the
> uio driver expects (IO BAR vs. MMIO BAR)

In what way? A quick look suggests that kvmtool is at least aligned with
said github repo.

> c) there is (at least one) bug in kvmtool (easily fixed, though)

Care to elaborate?

Will

  reply	other threads:[~2015-06-29 10:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-04 15:20 [PATCH] kvmtool: don't use PCI config space IRQ line field Andre Przywara
2015-06-04 15:20 ` Andre Przywara
2015-06-05 16:41 ` Will Deacon
2015-06-05 16:41   ` Will Deacon
2015-06-15 10:45   ` Andre Przywara
2015-06-15 10:45     ` Andre Przywara
2015-06-16 17:06     ` Will Deacon
2015-06-16 17:06       ` Will Deacon
2015-06-18 17:19       ` Andre Przywara
2015-06-18 17:19         ` Andre Przywara
2015-06-29 10:10         ` Will Deacon [this message]
2015-06-29 10:10           ` Will Deacon
2015-06-29 13:48           ` Andre Przywara
2015-06-29 13:48             ` Andre Przywara
  -- strict thread matches above, loose matches on Subject: below --
2015-02-03 11:31 [PATCH] PCI: Fix pcibios_update_irq misuse of irq number Arnd Bergmann
2015-02-04 15:39 ` [PATCH] kvmtool: don't use PCI config space IRQ line field Andre Przywara
2015-02-04 15:39   ` Andre Przywara
2015-02-06 18:55   ` Will Deacon
2015-02-06 18:55     ` Will Deacon
2015-02-06 19:02     ` Peter Maydell
2015-02-06 19:02       ` Peter Maydell
2015-02-06 19:07       ` Will Deacon
2015-02-06 19:07         ` Will Deacon
2015-02-07 21:24         ` arnd at arndb.de
2015-02-07 21:24           ` arnd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150629101004.GB17474@arm.com \
    --to=will.deacon@arm.com \
    --cc=andre.przywara@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.