All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <jroedel@suse.de>
To: Eric Auger <eric.auger@linaro.org>
Cc: Will Deacon <Will.Deacon@arm.com>,
	Baptiste Reynal <b.reynal@virtualopensystems.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Regression observed since "iommu: Propagate error in add_iommu_group" with arm-smmu
Date: Mon, 29 Jun 2015 15:16:56 +0200	[thread overview]
Message-ID: <20150629131656.GB16648@suse.de> (raw)
In-Reply-To: <55913E36.4010407@linaro.org>

Hi Eric

On Mon, Jun 29, 2015 at 02:46:46PM +0200, Eric Auger wrote:
> Hi Joerg, Will
> 
> I observe a regression since commit
> 19762d7095e6392b6ec56c363a6f29b2119488c2 (iommu: Propagate error in
> add_iommu_group) with arm-smmu: I am not able to bind the vfio-platform
> driver to one Calxeda Midway xgmac anymore. This latter is not assigned
> any group.
> 
> Looks like the cause is, in iommu_bus_init, when doing
> bus_for_each_dev(bus, NULL, &cb, add_iommu_group),
> add_iommu_group fails for some devices which are not upstream to smmu
> and enumerated before the xgmac. As a consequence  bus_for_each_dev
> returns without looking at the xgmac.
> 
> arm_smmu_add_platform_device currently returns -ENODEV when no smmu/no
> master port for the device. Shouldn't we return 0 now?

I posted a patch today which fixes this by ignoring -ENODEV as a return
value in add_iommu_group. See here:

	http://lists.linuxfoundation.org/pipermail/iommu/2015-June/013508.html

I'll send this fix upstream asap (means: tomorrow). It would be great if
you can test it too in your setup.


	Joerg


  reply	other threads:[~2015-06-29 13:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-29 12:46 Regression observed since "iommu: Propagate error in add_iommu_group" with arm-smmu Eric Auger
2015-06-29 13:16 ` Joerg Roedel [this message]
2015-06-29 13:32   ` Eric Auger
2015-06-29 13:43     ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150629131656.GB16648@suse.de \
    --to=jroedel@suse.de \
    --cc=Will.Deacon@arm.com \
    --cc=alex.williamson@redhat.com \
    --cc=b.reynal@virtualopensystems.com \
    --cc=eric.auger@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.