All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Michael Welling <mwelling@ieee.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.cz>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	Joerg Roedel <jroedel@suse.de>,
	Peter Hurley <peter@hurleysoftware.com>,
	Joe Schultz <jschultz@xes-inc.com>
Subject: Re: [PATCH] serial: 8250: Do XR17V35X specific wakeup in serial8250_do_startup
Date: Mon, 29 Jun 2015 17:26:30 +0200	[thread overview]
Message-ID: <20150629152630.GL18569@8bytes.org> (raw)
In-Reply-To: <20150619170910.GA6002@deathray>

On Fri, Jun 19, 2015 at 12:09:10PM -0500, Michael Welling wrote:
> 
> Looks good to me. The datasheet indicates that bit 4 of the EFR needs to be set to access
> to IER [7:5], ISR [5:4], FCR[5:4], MCR[7:5], MSR.

Thanks! I updated the patch a little bit and wrote a better changelog
entry, mentioning the above bits. Will send a new version after the
merge window.


	Joerg

  reply	other threads:[~2015-06-29 15:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-19 15:12 [PATCH] serial: 8250: Do XR17V35X specific wakeup in serial8250_do_startup Joerg Roedel
2015-06-19 15:12 ` Joerg Roedel
2015-06-19 17:09 ` Michael Welling
2015-06-19 17:09   ` Michael Welling
2015-06-29 15:26   ` Joerg Roedel [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-07-16  8:29 Joerg Roedel
2015-07-16  8:55 ` Michael Welling
2015-07-17 13:34 ` Peter Hurley
2015-07-28  7:20   ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150629152630.GL18569@8bytes.org \
    --to=joro@8bytes.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jroedel@suse.de \
    --cc=jschultz@xes-inc.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mwelling@ieee.org \
    --cc=peter@hurleysoftware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.