From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH]: MUX n_gsm debug print improvements Date: Mon, 29 Jun 2015 09:04:03 -0700 Message-ID: <20150629160403.GB7455@kroah.com> References: <1435593298.25711.4.camel@tldlab125> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1435593298.25711.4.camel@tldlab125> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Gwenn =?iso-8859-1?Q?Bourr=E9e?= Cc: jslaby-AlSwsSmVLrQ@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On Mon, Jun 29, 2015 at 05:54:58PM +0200, Gwenn Bourr=E9e wrote: >=20 > Dear kernel tty maintainers, >=20 > Please review the following patch: >=20 > From 0ac5da0a4653f43ce4b0761a2be8073185c549bb Mon Sep 17 00:00:00 200= 1 > From: Gwenn Bourree > Date: Mon, 29 Jun 2015 16:09:06 +0200 > Subject: [PATCH] Add Debug define >=20 > Improve the debug print out and make be clearest >=20 > Signed-off-by: Gwenn Bourree > Signed-off-by: Mustapha Ben Zoubeir > Signed-off-by: Nicolas LOUIS > Reviewed-by: Ravindran, Arun =20 > --- > drivers/tty/n_gsm.c | 49 > ++++++++++++++++++++++++++++--------------------- > 1 file changed, 28 insertions(+), 21 deletions(-) Also, your patch is line-wrapped and also base64 encoded, making it impossible to edit, or apply. Please fix up your email client to use the proper configuration, as I'm sure Intel has documentation for how t= o do. In fact, it has documentation for how to do all of this, why aren't you following it? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753229AbbF2QEK (ORCPT ); Mon, 29 Jun 2015 12:04:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45058 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752765AbbF2QEF (ORCPT ); Mon, 29 Jun 2015 12:04:05 -0400 Date: Mon, 29 Jun 2015 09:04:03 -0700 From: Greg KH To: Gwenn =?iso-8859-1?Q?Bourr=E9e?= Cc: jslaby@suse.cz, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH]: MUX n_gsm debug print improvements Message-ID: <20150629160403.GB7455@kroah.com> References: <1435593298.25711.4.camel@tldlab125> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1435593298.25711.4.camel@tldlab125> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 29, 2015 at 05:54:58PM +0200, Gwenn Bourrée wrote: > > Dear kernel tty maintainers, > > Please review the following patch: > > From 0ac5da0a4653f43ce4b0761a2be8073185c549bb Mon Sep 17 00:00:00 2001 > From: Gwenn Bourree > Date: Mon, 29 Jun 2015 16:09:06 +0200 > Subject: [PATCH] Add Debug define > > Improve the debug print out and make be clearest > > Signed-off-by: Gwenn Bourree > Signed-off-by: Mustapha Ben Zoubeir > Signed-off-by: Nicolas LOUIS > Reviewed-by: Ravindran, Arun > --- > drivers/tty/n_gsm.c | 49 > ++++++++++++++++++++++++++++--------------------- > 1 file changed, 28 insertions(+), 21 deletions(-) Also, your patch is line-wrapped and also base64 encoded, making it impossible to edit, or apply. Please fix up your email client to use the proper configuration, as I'm sure Intel has documentation for how to do. In fact, it has documentation for how to do all of this, why aren't you following it? thanks, greg k-h