From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753345AbbF2USH (ORCPT ); Mon, 29 Jun 2015 16:18:07 -0400 Received: from mail.kernel.org ([198.145.29.136]:43684 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752576AbbF2USA (ORCPT ); Mon, 29 Jun 2015 16:18:00 -0400 Date: Mon, 29 Jun 2015 17:17:56 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Adrian Hunter , Jiri Olsa , Kan Liang , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra Subject: Re: [PATCHv2 perf/core] perf tools: Add missing break for PERF_RECORD_ITRACE_START Message-ID: <20150629201756.GE1225@kernel.org> References: <1435576340-19346-1-git-send-email-jolsa@kernel.org> <5591293E.80308@intel.com> <20150629112745.GA21507@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150629112745.GA21507@krava.brq.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Jun 29, 2015 at 01:27:45PM +0200, Jiri Olsa escreveu: > On Mon, Jun 29, 2015 at 02:17:18PM +0300, Adrian Hunter wrote: > > But now you have break; break; > > hum, I did not see the PERF_RECORD_LOST_SAMPLES has 2 breaks already, > anyway the one for PERF_RECORD_ITRACE_START is missing > > > Isn't putting 'break' on the end of the line making things harder to read? > > I guess, but looks like we dont have firm style in this.. > attaching v2 with the extra break removal Thanks, applied. - Arnaldo