From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: remote attribute headers contain an invalid LSN
Date: Tue, 30 Jun 2015 09:11:40 +1000 [thread overview]
Message-ID: <20150629231140.GH7943@dastard> (raw)
In-Reply-To: <20150625124643.GA36162@bfoster.bfoster>
On Thu, Jun 25, 2015 at 08:46:44AM -0400, Brian Foster wrote:
> So as noted above, were this treated as a typical metadata block, the
> corresponding buffer would be logged and thus everything would be
> ordered appropriately with respect to the log. It is not a logged buffer
> in this case, so we drop XFS_BMAPI_METADATA flag from the allocation
> which would cause any previous frees of this block to be flushed to the
> ail.
Yes.
> I don't see anything explicit that "handles" the case of being written
> before the allocation transaction is committed. By "handles," do you
> simply mean the aforementioned log force? In other words, we're
> implicitly saying it's fine that the block is written out of order from
> the allocation, so long as the block is marked free on-disk.
Yes and yes.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-06-29 23:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 4:46 [PATCH] xfs: remote attribute headers contain an invalid LSN Dave Chinner
2015-06-24 13:12 ` Brian Foster
2015-06-24 21:26 ` Dave Chinner
2015-06-25 12:46 ` Brian Foster
2015-06-29 23:11 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150629231140.GH7943@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.