All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Hou Pengyang <houpengyang@huawei.com>
Cc: mingo@redhat.com, namhyung@kernel.org, a.p.zijlstra@chello.nl,
	wangnan0@huawei.com, linux-kernel@vger.kernel.org,
	zhu.wen-jie@hp.com
Subject: Re: [RFC] perf tools: Add hugetlbfs memory recognition
Date: Tue, 30 Jun 2015 11:50:49 -0300	[thread overview]
Message-ID: <20150630145049.GE5888@kernel.org> (raw)
In-Reply-To: <55926251.9000404@huawei.com>

Em Tue, Jun 30, 2015 at 05:33:05PM +0800, Hou Pengyang escreveu:
> On 2015/6/29 21:42, Arnaldo Carvalho de Melo wrote:
> >Em Mon, Jun 29, 2015 at 10:23:29AM -0300, Arnaldo Carvalho de Melo escreveu:
> >>Em Sat, Jun 27, 2015 at 05:08:20PM +0800, Hou Pengyang escreveu:
> >>>So I wonder if there is a need to read /proc/pid/smaps instead of
> >>>/proc/pid/maps to generate MMAP2 event. Or we should solve the problem by
> >>>another way?
> >>
> >>Doing some research now...
> >
> >Bummer, seems that only smaps -> ... -> show_smap_vma_flags() will
> >expose that to userspace...
> >
> >Perhaps we can look at some global stat for HugeTLB fs to figure out if
> >we really, really need to parse smaps instead of just maps? I.e. in my
> >system, a desktop one, F21, I have:
> >
> 
> It seems no other info tell us if one process is using hugetlbfs.
> So how about an option to tell perf explicitly which file is from
> hugetlbfs, like:
> 
> ./perf report --hugetlb-file=/mnt/huge/hugepagefile
> 
> So that, we can check if a mmap area is from hugetlbfs by its name
> instead of MAP_HUGETLB.

Well, we _can_ detect this automatically, its just a matter of parsing
/proc/PID/smaps, right?

What I was discussing was a way only parse smaps when we know we need
to, i.e. when we, for instance, parsing /proc/PID/maps, find a map that
we think may be a hugetlb one, maybe some other way to tell us that
hugetlb maps are in place, looking at the hugetlbfs stats somehow?

- Arnaldo

  reply	other threads:[~2015-06-30 14:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-27  8:49 [RFC] perf tools: Add hugetlbfs memory recognition Hou Pengyang
2015-06-27  9:08 ` Hou Pengyang
2015-06-29 13:23   ` Arnaldo Carvalho de Melo
2015-06-29 13:42     ` Arnaldo Carvalho de Melo
2015-06-30  9:33       ` Hou Pengyang
2015-06-30 14:50         ` Arnaldo Carvalho de Melo [this message]
2015-07-03 10:21           ` Hou Pengyang
2015-07-03 15:16             ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150630145049.GE5888@kernel.org \
    --to=acme@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=houpengyang@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=wangnan0@huawei.com \
    --cc=zhu.wen-jie@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.