From: Ravi Teja Darbha <ravi2j@gmail.com>
To: gregkh@linuxfoundation.org
Cc: joe@perches.com, fabio.falzoi84@gmail.com,
nizamhaider786@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH][RESEND] rts5208:Fix checkpatch warnings
Date: Wed, 1 Jul 2015 12:27:38 +0530 [thread overview]
Message-ID: <20150701065738.GA2128@gmail.com> (raw)
else is not generally useful after a break or return, hence removed.
Signed-off-by: Ravi Teja Darbha <ravi2j@gmail.com>
---
drivers/staging/rts5208/xd.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
index 10fea7b..42d8d82 100644
--- a/drivers/staging/rts5208/xd.c
+++ b/drivers/staging/rts5208/xd.c
@@ -1689,10 +1689,9 @@ static int xd_read_multiple_pages(struct rtsx_chip *chip, u32 phy_blk,
xd_set_err_code(chip, XD_TO_ERROR);
rtsx_trace(chip);
return STATUS_FAIL;
- } else {
- rtsx_trace(chip);
- goto Fail;
}
+ rtsx_trace(chip);
+ goto Fail;
}
return STATUS_SUCCESS;
@@ -1905,10 +1904,9 @@ static int xd_write_multiple_pages(struct rtsx_chip *chip, u32 old_blk,
xd_set_err_code(chip, XD_TO_ERROR);
rtsx_trace(chip);
return STATUS_FAIL;
- } else {
- rtsx_trace(chip);
- goto Fail;
}
+ rtsx_trace(chip);
+ goto Fail;
}
if (end_page == (xd_card->page_off + 1)) {
--
1.9.1
next reply other threads:[~2015-07-01 6:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 6:57 Ravi Teja Darbha [this message]
2015-07-15 3:18 ` [PATCH][RESEND] rts5208:Fix checkpatch warnings Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150701065738.GA2128@gmail.com \
--to=ravi2j@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.falzoi84@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nizamhaider786@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.