From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Michel von Czettritz <michel.von.czettritz@gmail.com>,
devel@driverdev.osuosl.org, gregkh@linux.com,
Larry.Finger@lwfinger.net, linux-wireless@vger.kernel.org,
Jes.Sorensen@redhat.com
Subject: Re: [PATCH 3/3] staging: rtl8723au: function no longer discards return value
Date: Wed, 1 Jul 2015 13:38:27 +0530 [thread overview]
Message-ID: <20150701080827.GE2411@sudip-PC> (raw)
In-Reply-To: <20150701075042.GT28762@mwanda>
On Wed, Jul 01, 2015 at 10:50:42AM +0300, Dan Carpenter wrote:
> On Wed, Jul 01, 2015 at 12:42:24PM +0530, Sudip Mukherjee wrote:
> > On Tue, Jun 30, 2015 at 11:54:59PM +0200, Michel von Czettritz wrote:
> > > The return value of FillH2CCmd in rtl8723a_set_rssi_cmd and
> > > rtl8723a_set_raid_cmd is never checked. Both functions always return
> > > _SUCCESS.
> > >
> > > Both functions now return the return value of FillH2CCmd.
> > If they are never checked then why do we need to return some value?
> > why not make them void?
>
> They probably *should* be checked eventually?
yes, they should check the sucess/failure of the commands. If that plan
is there to check the values afterwards then the patch is correct.
regards
sudip
next prev parent reply other threads:[~2015-07-01 8:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 21:52 [PATCH 0/3] staging: rtl8723au: fix/clean up two functions Michel von Czettritz
2015-06-30 21:53 ` [PATCH 1/3] staging: rtl8723au: adjust function param, u8* to u32* Michel von Czettritz
2015-06-30 21:54 ` [PATCH 2/3] staging: rtl8723au: fix "incorrect type in assignment" Michel von Czettritz
2015-07-01 7:06 ` Sudip Mukherjee
2015-07-01 7:56 ` Dan Carpenter
2015-07-01 20:34 ` Jes Sorensen
2015-07-01 20:31 ` Jes Sorensen
2015-07-01 23:36 ` Michel von Czettritz
2015-07-02 2:00 ` Jes Sorensen
2015-06-30 21:54 ` [PATCH 3/3] staging: rtl8723au: function no longer discards return value Michel von Czettritz
2015-07-01 7:12 ` Sudip Mukherjee
2015-07-01 7:50 ` Dan Carpenter
2015-07-01 8:08 ` Sudip Mukherjee [this message]
2015-07-01 16:50 ` Michel von Czettritz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150701080827.GE2411@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linux.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michel.von.czettritz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.