From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH -stable] netfilter: nft_rbtree: fix locking
Date: Wed, 1 Jul 2015 13:38:46 +0200 [thread overview]
Message-ID: <20150701113846.GA18976@salvia> (raw)
In-Reply-To: <20150629230053.GC19806@kroah.com>
On Mon, Jun 29, 2015 at 04:00:53PM -0700, Greg KH wrote:
> On Sat, May 16, 2015 at 08:50:51PM +0200, Pablo Neira Ayuso wrote:
> > From: Patrick McHardy <kaber@trash.net>
> >
> > [ upstream commit 16c45eda96038aae848b6cfd42e2bf4b5e80f365 ]
> >
> > Fix a race condition and unnecessary locking:
> >
> > * the root rb_node must only be accessed under the lock in nft_rbtree_lookup()
> > * the lock is not needed in lookup functions in netlink context
> >
> > Cc: <stable@vger.kernel.org> # 3.18.x
> > Cc: <stable@vger.kernel.org> # 3.19.x
> > Signed-off-by: Patrick McHardy <kaber@trash.net>
> > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> > ---
> > net/netfilter/nft_rbtree.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
>
> Also 4.0, right? This showed up in Linus's tree in 4.1-rc1.
Yes please. thanks!
next prev parent reply other threads:[~2015-07-01 11:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-16 18:50 [PATCH -stable] netfilter: nf_tables: fix error handling of rule replacement Pablo Neira Ayuso
2015-05-16 18:50 ` [PATCH -stable] netfilter: Zero the tuple in nfnl_cthelper_parse_tuple() Pablo Neira Ayuso
2015-05-19 11:31 ` Jiri Slaby
2015-05-16 18:50 ` [PATCH -stable] netfilter: nf_tables: check for overflow of rule dlen field Pablo Neira Ayuso
2015-05-16 18:50 ` [PATCH -stable] netfilter: nft_compat: set IP6T_F_PROTO flag if protocol is set Pablo Neira Ayuso
2015-05-16 18:50 ` [PATCH -stable] netfilter: restore rule tracing via nfnetlink_log Pablo Neira Ayuso
2015-05-16 18:50 ` [PATCH -stable] netfilter: nf_tables: allow to change chain policy without hook if it exists Pablo Neira Ayuso
2015-05-16 18:50 ` [PATCH -stable] netfilter: nft_rbtree: fix locking Pablo Neira Ayuso
2015-06-29 23:00 ` Greg KH
2015-07-01 11:38 ` Pablo Neira Ayuso [this message]
2015-05-20 12:12 ` [PATCH -stable] netfilter: nf_tables: fix error handling of rule replacement Luis Henriques
2015-05-20 12:12 ` Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150701113846.GA18976@salvia \
--to=pablo@netfilter.org \
--cc=gregkh@linuxfoundation.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.