From: Oleg Nesterov <oleg@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Benjamin LaHaise <bcrl@kvack.org>,
Hugh Dickins <hughd@google.com>, Jeff Moyer <jmoyer@redhat.com>,
Kirill Shutemov <kirill.shutemov@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] mremap: don't leak new_vma if f_op->mremap() fails
Date: Wed, 1 Jul 2015 17:46:23 +0200 [thread overview]
Message-ID: <20150701154623.GA14934@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1506301530300.24266@chino.kir.corp.google.com>
On 06/30, David Rientjes wrote:
>
> On Sat, 20 Jun 2015, Oleg Nesterov wrote:
>
> > move_vma() can't just return if f_op->mremap() fails, we should
> > unmap the new vma like we do if move_page_tables() fails. To avoid
> > the code duplication this patch moves the "move entries back" under
> > the new "if (err)" branch.
> >
> > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
>
> Looks good! I think it was sniped by commit 4abad2ca4a4d ("mm: new
> arch_remap() hook")
No, it was b2edffdd912b "fix mremap() vs. ioctx_kill() race"
> so it needs to be rebased,
Yes, thanks, I'll rebase...
But you know, I think 4abad2ca4a4d ("mm: new arch_remap() hook") should
be reverted later. Please see
[PATCH v2 1/1] mm: move ->mremap() from file_operations to vm_operations_struct
http://marc.info/?l=linux-kernel&m=143526519407521
I think arch_remap() should be turned into special_mapping_vmops->nremap().
But this is off-topic right now.
> but after that feel free to add my
>
Acked-by: David Rientjes <rientjes@google.com>
Thanks!
Oleg.
next prev parent reply other threads:[~2015-07-01 15:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 23:18 [PATCH 0/4] mremap fix/cleanups Oleg Nesterov
2015-06-19 23:19 ` [PATCH 1/4] mremap: don't leak new_vma if f_op->mremap() fails Oleg Nesterov
2015-06-30 22:31 ` David Rientjes
2015-07-01 15:46 ` Oleg Nesterov [this message]
2015-07-01 22:55 ` David Rientjes
2015-06-19 23:19 ` [PATCH 2/4] mremap: don't do mm_populate(new_addr) on failure Oleg Nesterov
2015-06-30 22:34 ` David Rientjes
2015-07-01 15:47 ` Oleg Nesterov
2015-07-01 21:45 ` David Rientjes
2015-07-01 22:41 ` Oleg Nesterov
2015-06-19 23:19 ` [PATCH 3/4] mremap: don't do uneccesary checks if new_len == old_len Oleg Nesterov
2015-06-30 22:36 ` David Rientjes
2015-06-19 23:19 ` [PATCH 4/4] mremap: simplify the "overlap" check in mremap_to() Oleg Nesterov
2015-06-30 22:45 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150701154623.GA14934@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=hughd@google.com \
--cc=jmoyer@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.