From: Aurelien Jarno <aurelien@aurel32.net>
To: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
Cc: pbonzini@redhat.com, rth7680@gmail.com, leon.alrae@imgtec.com,
qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH v4 1/5] softmmu: add helper function to pass through retaddr
Date: Wed, 1 Jul 2015 18:16:41 +0200 [thread overview]
Message-ID: <20150701161641.GA23093@aurel32.net> (raw)
In-Reply-To: <20150629072317.388.56900.stgit@PASHA-ISP>
On 2015-06-29 10:23, Pavel Dovgalyuk wrote:
> This patch introduces several helpers to pass return address
> which points to the TB. Correct return address allows correct
> restoring of the guest PC and icount. These functions should be used when
> helpers embedded into TB invoke memory operations.
>
> Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
> ---
> include/exec/cpu_ldst_template.h | 59 +++++++++++++++++++++++++++++++++-----
> softmmu_template.h | 6 ----
> tcg/tcg.h | 23 +++++++++++++++
> 3 files changed, 74 insertions(+), 14 deletions(-)
This patch doesn't provide the equivalent _ra functions for the user mode
code, so it causes any linux-user target using this to fail to build. I don't
think we want to special case this kind of code in the target code, so
they need to be provided.
Otherwise it looks ok.
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2015-07-01 16:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 7:23 [Qemu-devel] [PATCH v4 0/5] Fix exceptions handling for MIPS and i386 Pavel Dovgalyuk
2015-06-29 7:23 ` [Qemu-devel] [PATCH v4 1/5] softmmu: add helper function to pass through retaddr Pavel Dovgalyuk
2015-07-01 9:00 ` Richard Henderson
2015-07-01 16:16 ` Aurelien Jarno [this message]
2015-06-29 7:23 ` [Qemu-devel] [PATCH v4 2/5] cpu-exec: introduce loop exit with restore function Pavel Dovgalyuk
2015-07-01 9:02 ` Richard Henderson
2015-07-01 16:30 ` Aurelien Jarno
2015-06-29 7:23 ` [Qemu-devel] [PATCH v4 3/5] target-mips: improve exceptions handling Pavel Dovgalyuk
2015-07-01 16:37 ` Aurelien Jarno
2015-06-29 7:23 ` [Qemu-devel] [PATCH v4 4/5] target-i386: fix memory operations in helpers Pavel Dovgalyuk
2015-07-01 9:17 ` Richard Henderson
2015-07-01 9:22 ` Pavel Dovgaluk
2015-07-01 9:26 ` Richard Henderson
2015-06-29 7:23 ` [Qemu-devel] [PATCH v4 5/5] target-ppc: exceptions handling in icount mode Pavel Dovgalyuk
2015-06-29 7:24 ` [Qemu-devel] [PATCH v4 0/5] Fix exceptions handling for MIPS and i386 Pavel Dovgaluk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150701161641.GA23093@aurel32.net \
--to=aurelien@aurel32.net \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=agraf@suse.de \
--cc=leon.alrae@imgtec.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth7680@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.