All of lore.kernel.org
 help / color / mirror / Atom feed
From: jonathan.derrick@intel.com (Jon Derrick)
Subject: [PATCHv2 2/2] NVMe: Use CMB for the SQ if available
Date: Wed, 1 Jul 2015 10:54:48 -0600	[thread overview]
Message-ID: <20150701165448.GA3290@localhost.localdomain> (raw)
In-Reply-To: <36F6EBABA23FEF4391AF72944D228901EB289031@BBYEXM02.pmc-sierra.internal>

Hi Stephen,

Thanks for reviewing

> This seems a little backwards to me in the sense that if the drive advertises CMB with SQ support the host is forced into using the CMB for SQs. Surely the host should have some ability to over-ride what the drive says? At the very least an argument into the  module to ignore CMB capabilities seems appropriate.

That seems like a good idea to allow it to be disabled as a module param

>Ultimately it would be good to have the host have the ability to use its preference when a device is reset. Or am I missing something?

Would using a module param cover your concerns here?

  reply	other threads:[~2015-07-01 16:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 22:33 [PATCHv2 0/2] NVMe: Enable SQes on the CMB Jon Derrick
2015-06-23 22:33 ` [PATCHv2 1/2] NVMe: Unify SQ entry writing and doorbell ringing Jon Derrick
2015-06-23 22:33 ` [PATCHv2 2/2] NVMe: Use CMB for the SQ if available Jon Derrick
2015-06-24 12:21   ` Christoph Hellwig
2015-07-01  8:10   ` Stephen Bates
2015-07-01 16:54     ` Jon Derrick [this message]
2015-07-01 19:14       ` Stephen Bates

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150701165448.GA3290@localhost.localdomain \
    --to=jonathan.derrick@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.