Re: [PATCH v12 3/8] tools: Add vmware_hwver support

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Sat, Jun 27, 2015 at 07:27:40PM -0400, Don Slutz wrote:
> From: Don Slutz <dslutz@verizon.com>
> 
> This is used to set xen_arch_domainconfig vmware_hw. It is set to
> the emulated VMware virtual hardware version.
> 
> Currently 0, 3-4, 6-11 are good values.  However the code only
> checks for == 0, != 0, or < 7.
> 
> Signed-off-by: Don Slutz <dslutz@verizon.com>
> CC: Don Slutz <don.slutz@gmail.com>
> ---
> v12:
>     I'm not sure this hunk has anything to do with this patch, nor
>     what the semantic difference between the old and new text is
>     supposed to be.
>       Dropped comment change.
> 
> 
> v11:
>   Dropped "If non-zero then default VGA to VMware's VGA"
> 
> v10:
>     LIBXL_HAVE_LIBXL_VGA_INTERFACE_TYPE_VMWARE &
>     LIBXL_HAVE_BUILDINFO_HVM_VMWARE_HWVER are arriving together
>     a single umbrella could be used.
>       Since I split the LIBXL_VGA_INTERFACE_TYPE_VMWARE into
>       it's own patch, this is not longer true.
>       But I did use 1 for the 2 c_info changes.
>     Please use GCSPRINTF.
>   Remove vga=vmware from here.
> 
> v9:
>       I assumed that s/vmware_hw/vmware_hwver/ is not a big enough
>       change to drop the Reviewed-by.  Did a minor edit to the
>       commit message to add 7 to the list of values checked.
> 
> v7:
>     Default handling of hvm.vga.kind bad.
>       Fixed.
>     Default of vmware_port should be based on vmware_hw.
>       Done. 
> 
> v5:
>       Anything looking for Xen according to the Xen cpuid instructions...
>         Adjusted doc to new wording.
> 
>  docs/man/xl.cfg.pod.5       | 17 +++++++++++++++++
>  tools/libxl/libxl_create.c  |  4 +++-
>  tools/libxl/libxl_types.idl |  1 +
>  tools/libxl/libxl_x86.c     |  3 +--
>  tools/libxl/xl_cmdimpl.c    |  2 ++
>  5 files changed, 24 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5
> index 84078f6..4a01527 100644
> --- a/docs/man/xl.cfg.pod.5
> +++ b/docs/man/xl.cfg.pod.5
> @@ -1348,6 +1348,23 @@ The viridian option can be specified as a boolean. A value of true (1)
>  is equivalent to the list [ "defaults" ], and a value of false (0) is
>  equivalent to an empty list.
>  
> +=item B<vmware_hwver=NUMBER>
> +
> +Turns on or off the exposure of VMware cpuid.  The number is
> +VMware's hardware version number, where 0 is off.  A number >= 7
> +is needed to enable exposure of VMware cpuid.
> +
> +The hardware version number (vmware_hwver) comes from VMware config files.
> +
> +=over 4
> +
> +In a .vmx it is virtualHW.version
> +
> +In a .ovf it is part of the value of vssd:VirtualSystemType.
> +For vssd:VirtualSystemType == vmx-07, vmware_hwver = 7.
> +
> +=back
> +

Perhaps add 'Recommended value is 7' ?